New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(minify): minify CSS and JavaScript #61

Open

Kristinita wants to merge 1 commit into noeldelgado:master from Kristinita:SashaDevelop

Kristinita commented May 8, 2018

1. Summary

I minify index.js and gemini-scrollbar.css.

2. Argumentation

Is it a good idea to minify my HTML, CSS, JavaScript, and PHP code?

3. Environment

I minify files use default settings of this minifiers:

cssnano 3.10.0
Uglify JS 3.3.24

Thanks.


          perf(minify): minify CSS and JavaScript

afc89b6

Use cssnano and Uglify JS

Author

Kristinita commented Feb 19, 2019

@noeldelgado , ping.

Thanks.

Author

Kristinita commented Sep 23, 2020

Type: Additional arguments ➕

@noeldelgado, I’m not sure, that ignoring pull requests is the best strategy.

CDN

Yes, jsDelivr can automatically minify files. Example — https://cdn.jsdelivr.net/npm/[email protected]/index.min.js. But:

Other services may not automatically minify files.
See the comment of jsDelivr founder:

Yes, we do minify manually some files but the difference is that we can check for validity. The bot cant do that, it will simply upload the output of the tool.

And we still prefer to ask the authors to include official minified files to remove all responsibility from us.

Ideally we want to enable auto-updates on all projects and have all authors include minified files.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet