Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm8+): refactor symlinking to support npm 9+ #264

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

Mairu
Copy link
Contributor

@Mairu Mairu commented Nov 22, 2023

The tarballs of npm 9 and newer don't contain the symlink files anymore. I therefore refactored the symlinking logic to use information from the package-lock.json instead which works for npm 8 and newer.

@Mairu Mairu self-assigned this Nov 22, 2023
@Mairu Mairu merged commit 89f7226 into nodists:master Nov 22, 2023
1 check passed
@Mairu Mairu deleted the npm-fix branch November 22, 2023 16:26
@nullivex
Copy link
Member

@Mairu I like this approach. Good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants