Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CCS811 Air Quality Sensor #3404

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

wbvreeuwijk
Copy link

Adds support for CCS811 sensor

Make sure all boxes are checked (add x inside the brackets) when you submit your contribution, remove this sentence before doing so.

  • This PR is for the dev branch rather than for the release branch.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/*.

<Needed support for CC811 Air quality sensor>

@wbvreeuwijk
Copy link
Author

First attempt at adding hardware support to NodeMCU. Support for CCS811 Air quality sensor.

@wbvreeuwijk wbvreeuwijk changed the title Ccs811 dev New Module: CCS811 Air Quality Sensor Mar 2, 2021
@wbvreeuwijk wbvreeuwijk changed the title New Module: CCS811 Air Quality Sensor Add support for CCS811 Air Quality Sensor Mar 2, 2021
Copy link
Member

@nwf nwf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider instead writing this driver in Lua. The device speaks I2C and has no strict timing requirements. There isn't even any really fiddly numeric work to be done. See https://github.com/nodemcu/nodemcu-firmware/blob/release/lua_modules/mcp23017/mcp23017.lua for an example.

@wbvreeuwijk
Copy link
Author

Please consider instead writing this driver in Lua. The device speaks I2C and has no strict timing requirements. There isn't even any really fiddly numeric work to be done. See https://github.com/nodemcu/nodemcu-firmware/blob/release/lua_modules/mcp23017/mcp23017.lua for an example.

This is something I have considered and this can be said for a number of modules that now make up this project. For my projects I prefer to have the hardware interaction abstracted and not having to load a number of modules in Lua to complete my project.

The module is build, the documentation has been created and can be incorporated. If you prefer not to include it as such then that's fine.

@serg3295
Copy link

In the documentation, the example for the error() function is the same as for the app_version() one. It is possible that this is a mistake.

Fixed issue with the example code for the error function
Removed incorrect Unicode character
@wbvreeuwijk
Copy link
Author

@serg3295 good catch. I updated the documentation.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@stale stale bot closed this Apr 30, 2022
@HHHartmann
Copy link
Member

I feel we shouldn't close finished PRs. If we don't want them they still can help someone else

@HHHartmann HHHartmann reopened this May 1, 2022
@stale stale bot removed the stale label May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants