-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CCS811 Air Quality Sensor #3404
base: dev
Are you sure you want to change the base?
Conversation
First attempt at adding hardware support to NodeMCU. Support for CCS811 Air quality sensor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider instead writing this driver in Lua. The device speaks I2C and has no strict timing requirements. There isn't even any really fiddly numeric work to be done. See https://github.com/nodemcu/nodemcu-firmware/blob/release/lua_modules/mcp23017/mcp23017.lua for an example.
This is something I have considered and this can be said for a number of modules that now make up this project. For my projects I prefer to have the hardware interaction abstracted and not having to load a number of modules in Lua to complete my project. The module is build, the documentation has been created and can be incorporated. If you prefer not to include it as such then that's fine. |
In the documentation, the example for the error() function is the same as for the app_version() one. It is possible that this is a mistake. |
Fixed issue with the example code for the error function
Removed incorrect Unicode character
@serg3295 good catch. I updated the documentation. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I feel we shouldn't close finished PRs. If we don't want them they still can help someone else |
Adds support for CCS811 sensor
Make sure all boxes are checked (add x inside the brackets) when you submit your contribution, remove this sentence before doing so.
dev
branch rather than for therelease
branch.docs/*
.<Needed support for CC811 Air quality sensor>