Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sntp: simplify and tidy a bit #2700

Merged
merged 1 commit into from
Jul 27, 2019
Merged

sntp: simplify and tidy a bit #2700

merged 1 commit into from
Jul 27, 2019

Commits on Jul 27, 2019

  1. sntp: simplify and tidy a bit

    * list_ref can become LUA_REFNIL, because that's what rawgeti returns
      for LUA_NOREF.  Defensively guard for this, rather than falling into
      the sntp_dolookups loop with nil on the stack.
    
    * set_repeat_mode should not call itself, but should rather always do
      what it's going to do and then optionally do the rest if directed.
    
    * sntp_sync should not try to special case the single string argument:
      we should be queueing that name for DNS resolution, too.  Towards that
      end, if we are given a single string, build a table and make that the
      list_ref and call off to sntp_dolookups, just like we otherwise do.
    
    FIXES: nodemcu#2699
    nwf committed Jul 27, 2019
    Configuration menu
    Copy the full SHA
    446760c View commit details
    Browse the repository at this point in the history