doc: doc how to add message for promotion #55843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document the process for adding a message that ambassadors will be asked to promote. Signed-off-by: Michael Dawson <[email protected]>
|
Review requested:
|
|
@nodejs/node as discussed today. Let me know if there is anything else I should add or suggestions for improvement. |
RedYetiDev
reviewed
Nov 13, 2024
That's not a valid team. I assume you meant the TSC? (Just in case you didn't, I haven't pinged anyone) |
The bot has already pinged the TSC in #55843 (comment) |
gireeshpunathil
approved these changes
Nov 14, 2024
Co-authored-by: Aviv Keller <[email protected]>
Co-authored-by: Gireesh Punathil <[email protected]>
|
@RedYetiDev correct I meant the TSC should be at mentioned for additions to the messages, thanks for catching that. EDIT: I thought you meant in the doc, but see it was my atttempted mention to the next-10 team |
|
@nodejs/next-10 is what I meant to mention. |
marco-ippolito
approved these changes
Nov 19, 2024
aduh95
added
the
author ready
mhdawson
added
the
commit-queue-squash
jasnell
approved these changes
Nov 23, 2024
RafaelGSS
approved these changes
Nov 23, 2024
jasnell
pushed a commit
that referenced
this pull request
Nov 23, 2024
Document the process for adding a message that ambassadors will be asked to promote. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #55843 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
|
Landed in 3218698 |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
Document the process for adding a message that ambassadors will be asked to promote. Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#55843 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Nov 26, 2024
Document the process for adding a message that ambassadors will be asked to promote. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #55843 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the process for adding a message that
ambassadors will be asked to promote.