fix: NodeJS build for M1 iOS simulator #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dejakob How can I merge your version of the code before it is merged? |
|
This fix works for me on Apple Silicons. Any plans to merge this PR? |
|
Yes, some plans. But we have to update it for Node.js 16.x |
|
This PR works for me on a M2, the NodeMobile.framework also became lighter. 44.7 MB instead of 53.1 MB. |
|
@staltz Any plans to merge this PR? |
|
It has merge conflicts, so it's not in shape to be merged. |
|
Is there an update on the status of merging this PR? It's been a while, and I'm curious to know how much longer it might take for it to be merged. |
|
I've been able to use nodejs-mobile-react-native on an M1 Mac targeting iOS Simulator, e.g. this week and last week. So it seems to me this PR is no longer needed? |
|
Working fine on my M2! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As pointed out in issues #10 and #7, the framework is not supported when using on a simulator on a M1 Macbook.
Thanks to JaneaSystems/nodejs-mobile#340 I was able to create another build of the mobile-nodejs framework that supports both architectures of a simulator and an actual device.