Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ci-shark-ai.yml to pkgci_shark_ai.yml #780

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

renxida
Copy link
Contributor

@renxida renxida commented Jan 8, 2025

Plan:

grab scott's old shark-ai-pkgci from #625
apply the changes to current main
trigger the current build_packages.yml (from #667 ) instead of creating a separate build_packages_pkgci.yml
apply improvements to setup_venv.py

@renxida renxida changed the title [skip ci] initial commit using scotts code Convert ci-shark-ai.yml to pkgci_shark_ai.yml Jan 8, 2025
name: PkgCI

on:
workflow_dispatch:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI you can test workflows using this workflow_dispatch trigger without needing to send a pull request. You can also run on any triggers you want from your fork, so long as you don't try to use self-hosted runners that only exist in this repository.

I usually do that whenever I'm iterating on workflows to avoid generating too much noise in the main repository and triggering unrelated workflows when they aren't configured with something like the "skip ci" that you tried ;). Workflows in IREE are configurable via git trailers: https://iree.dev/developers/general/contributing/#ci-behavior-manipulation, but we haven't built anything like that in this repository yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skipci did work to skip all the workflows, but my problem was that the PkgCI workflow didn't show up for manual triggering : /

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renxida
Copy link
Contributor Author

renxida commented Jan 8, 2025

TODO: add tracing related script changes from #625

@renxida
Copy link
Contributor Author

renxida commented Jan 8, 2025

TODO: add venv creation script improvements scott made in iree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants