-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert ci-shark-ai.yml
to pkgci_shark_ai.yml
#780
base: main
Are you sure you want to change the base?
Conversation
ci-shark-ai.yml
to pkgci_shark_ai.yml
02abe82
to
b7af624
Compare
name: PkgCI | ||
|
||
on: | ||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI you can test workflows using this workflow_dispatch
trigger without needing to send a pull request. You can also run on any triggers you want from your fork, so long as you don't try to use self-hosted runners that only exist in this repository.
I usually do that whenever I'm iterating on workflows to avoid generating too much noise in the main repository and triggering unrelated workflows when they aren't configured with something like the "skip ci" that you tried ;). Workflows in IREE are configurable via git trailers: https://iree.dev/developers/general/contributing/#ci-behavior-manipulation, but we haven't built anything like that in this repository yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skipci did work to skip all the workflows, but my problem was that the PkgCI workflow didn't show up for manual triggering : /
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I think https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/skipping-workflow-runs is all-or-nothing.
TODO: add tracing related script changes from #625 |
TODO: add venv creation script improvements scott made in iree |
6eb4757
to
9e0df9a
Compare
Plan:
grab scott's old shark-ai-pkgci from #625
apply the changes to current main
trigger the current build_packages.yml (from #667 ) instead of creating a separate build_packages_pkgci.yml
apply improvements to setup_venv.py