Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new readme #37

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Add a new readme #37

merged 3 commits into from
Dec 23, 2024

Conversation

Jean-BaptisteC
Copy link
Contributor

@Jean-BaptisteC Jean-BaptisteC commented Apr 27, 2024

This PR upgrade readme:

  • Add app logo
  • Add short description of app
  • Add badges for each app stores
  • Add links to different website

Todo:

  • Need help to fix alignment of app store badge

@Jean-BaptisteC
Copy link
Contributor Author

@OtterWays any chance this PR will be review in the next months?

@OtterWays
Copy link
Collaborator

@OtterWays any chance this PR will be review in the next months?

Sorry! I'll do the review within the week

@Jean-BaptisteC
Copy link
Contributor Author

Jean-BaptisteC commented Aug 4, 2024

No problem :)
I have planned to rebase branch and update some things ->Done

@Jean-BaptisteC Jean-BaptisteC force-pushed the readme branch 3 times, most recently from 7dd765e to 9c5f844 Compare August 4, 2024 19:40
@Jean-BaptisteC
Copy link
Contributor Author

@OtterWays ready to be review

Rework readme and add images and links around the panoramax project
@antoine-de
Copy link

What is blocking the merge of this PR?

@Jean-BaptisteC
Copy link
Contributor Author

Jean-BaptisteC commented Dec 17, 2024

IMO nothing, just @OtterWays has not take time to review

Result is available here https://github.com/Jean-BaptisteC/panoramax-mobile-app/tree/readme

README.md Show resolved Hide resolved
@antoine-de
Copy link

If she's not available, I think we can move on with this (I'd only only show the download logo from where it's currently possible, else it could mislead some users)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@antoine-de
Copy link

it seems the CI is failing:

[!] Using compileSdk 35 requires Android Gradle Plugin (AGP) 8.1.0 or higher.                    │
│  Please upgrade to a newer AGP version. The version of AGP that your project uses is likely      │
│  defined in:  

It seems that we should upgrade AGP or downgrade the compileSdk version (I don't know the implications of those choices 😅 )

@Jean-BaptisteC
Copy link
Contributor Author

Upgrade sdk require to doing a code migration
https://developer.android.com/about/versions/15/migration
Downgrade sdk require to remove part of code specific about new sdk

SDK 35 is new the new sdk to add support for Android 15

@antoine-de
Copy link

@Jean-BaptisteC do you think you could give me the right to approve and merge PR on this repository? I think lots of incoming changes are stalled and it would be easier to merge those before migrating to gitlab

@Jean-BaptisteC
Copy link
Contributor Author

Jean-BaptisteC commented Dec 23, 2024

I have no right on this repository 😕
Maybe ask to @luifr10

@luifr10
Copy link
Contributor

luifr10 commented Dec 23, 2024

I have no right on this repository 😕 Maybe ask to @luifr10

Hello,

Indeed, I can grant you the right to merge code, but I need a confirmation that your are a member of Panoramax Team.

@luifr10 luifr10 merged commit ce735a5 into nobelization:main Dec 23, 2024
1 check failed
@Jean-BaptisteC Jean-BaptisteC deleted the readme branch December 23, 2024 18:30
@Jean-BaptisteC
Copy link
Contributor Author

Panoramax Team is defined here
https://gitlab.com/groups/panoramax/-/group_members

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants