Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tizen/Web] Refactoring ImageClassificationOffloading example #339

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

niley7464
Copy link
Contributor

  • Create utility module
  • Functionalization of duplicated part
  • Remove unused variables
  • Change var variables to use let type
  • Declare variables closer to where they are used

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 7, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #339. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niley7464, 💯 All CI checkers are successfully verified. Thanks.

@niley7464 niley7464 force-pushed the refactoring/tizen/web branch from 85f3793 to 2550486 Compare June 10, 2024 05:47
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niley7464, 💯 All CI checkers are successfully verified. Thanks.

@niley7464 niley7464 force-pushed the refactoring/tizen/web branch from 2550486 to 4a8423e Compare June 12, 2024 01:19
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niley7464, 💯 All CI checkers are successfully verified. Thanks.

- Create utility module
- Functionalization of duplicated part
- Remove unused variables
- Change var variables to use let type
- Declare variables closer to where they are used

Signed-off-by: Yelin Jeong <[email protected]>
Copy link
Member

@myungjoo myungjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update SPDX identifiers.

There is no "Apache-2.0-only". Use "Apache-2.0".
LGPL-2.0-only has some context...

@niley7464 niley7464 force-pushed the refactoring/tizen/web branch from 4a8423e to ab9847d Compare June 12, 2024 02:12
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niley7464, 💯 All CI checkers are successfully verified. Thanks.

@wooksong wooksong merged commit c2b7e9e into nnstreamer:main Jun 12, 2024
29 checks passed
@niley7464 niley7464 deleted the refactoring/tizen/web branch June 12, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants