Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in Table Headers for transaction card #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joker234
Copy link
Member

No description provided.

@Merovius
Copy link
Contributor

"Betrag" is numeric. According to the example that's the correct way to write numeric columns. I'll close this for now, reopen it if you disagree :)

@Merovius Merovius closed this Sep 13, 2015
@joker234
Copy link
Member Author

Mmmh you seem to be right. So other headings are numeric too. In my opinion, hex-numbers are numeric too. If Time is numeric to may be discussed. The other Question is, why the numeric cells are left aligned. This isn't very pretty for currency-formatting.

I'll reopen the pr and send patches to this branch. Please comment on my comments.

@joker234 joker234 reopened this Sep 13, 2015
@Merovius
Copy link
Contributor

In my opinion, hex-numbers are numeric too. If Time is numeric to may be discussed.

I'd put neither down as numeric. I assume numeric is important for two things: Alignment (see below) and Sort order. I assume that's what this is for and for both I would assume uid and time to be non-numerical.

The other Question is, why the numeric cells are left aligned. This isn't very pretty for currency-formatting.

According to the material design spec numeric columns should be right-aligned. If that's not the case for us, we should debug this and possibly report a bug against material design light.

BTW: This spec also contains stuff about inline editing that might be interesting for #27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants