Merge pull request #26 from dunglas/chore/useless-check

chore: remove redundant checks in basicParser
nlnwa · Sep 16, 2024 · 6ec50d6 · 6ec50d6
2 parents 914dda2 + 489cacd
commit 6ec50d6
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/url/parser.go b/url/parser.go
@@ -216,13 +216,13 @@ func (p *parser) basicParser(urlOrRef string, base *Url, url *Url, stateOverride
 				if err := p.handleError(url, errors.MissingSchemeNonRelativeURL, true); err != nil {
 					return nil, err
 				}
-			} else if base != nil && base.path.isOpaque() && r == '#' {
+			} else if base.path.isOpaque() && r == '#' {
 				url.scheme = base.scheme
 				url.path = base.path // TODO: Ensure copy????
 				url.query = base.query
 				url.fragment = new(string)
 				state = stateFragment
-			} else if base != nil && base.scheme != "file" {
+			} else if base.scheme != "file" {
 				state = stateRelative
 				input.rewindLast()
 			} else {