chore: enable clippy::wrong_self_convention and clippy::upper_case_acronyms #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch enables `clippy::wrong_self_convention` and fixes the one related issue.
This patch enables `clippy::upper_case_acronyms` and addresses related issues.
This patch re-enables `clippy::declare_interior_mutable_const` and addresses the issues related to the lint.
This patch re-enables `clippy::borrow_interior_mutable_const`. The issues connected with it seem to no longer be an issue.
This patch re-enables `clippy::module_inception`, and addresses the related issues. This required renaming two modules to use an underscore, which is probably not the best solution, but makes minimal changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch re-enables two clippy lints that were disabled when clippy was added, and addresses the issues connected with it.