-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several override additions and fixes #1836
Conversation
overrides/default.nix
Outdated
sed -i 's/"Framework :: MkDocs",//' pyproject.toml | ||
postPatch = old.postPatch or "" + lib.optionalString (old.version == "8.5.4") '' | ||
sed -i 's/filename = "requirements.txt"//' pyproject.toml | ||
sed -i '/\[project\]/a dependencies = ["jinja2>=3.0.2", "markdown>=3.2", "mkdocs>=1.3", "mkdocs-material-extensions>=1.0.3", "pygments>=2.12", "pymdown-extensions>=9.4", "requests>=2.26"]' pyproject.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, why the "Framework :: MkDocs",
was sed
ed away, it works without for me. This solution doesn't look pretty, but I don't know how else to solve the problem (see commit message).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a pyproject.toml
that fails without the second sed line?
A simple test derivation that only depends on mkdocs-material = "8.5.4"
builds for me with only the line that removes filename = "requirements.txt"
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed up a simpler replacement that only replaces filename = "requirements.txt"
. Let me know if that works for you, and then we can merge this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to double check, if everything works without specifying the dependencies, like coloring of code with pygments, but poetry lock
already resolves the dependencies. So I guess it's fine. Yet, I added mkdocs-get-deps and now something on darwin fails. Cannot reproduce locally as I don't have darwin. Can also be merged without the last commit.
95f748d
to
019364d
Compare
Somehow, this is broken. It always raises `ValueError: Cannot specify 'filename' in [tool.hatch.metadata.hooks.requirements_txt] when 'dependencies' is not listed in 'project.dynamic'.`, but everything looks good. So I decided to fix it with this "hack".
The issue is with the macOS SDK. It seems like |
Contribution checklist (recommended but not always applicable/required):