WIP: Xonsh

[pasqui23]

Description

Checklist

• Change is backwards compatible.

• Code formatted with ./format.

• Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• If this PR adds a new module

  • Added myself as module maintainer. See example.

Maintainer CC

[yajo]

Suggested change

	description = "Package that will actually gat installed";
	description = "Package that will actually get installed";

[yajo]

I think it's better to respect XDG.

Suggested change

	home = {
	packages = [ cfg.finalPackage ];
	file.".xonshrc" = {
	enable = cfg.xonshrc != "";
	text = cfg.xonshrc;
	};
	};
	home.packages = [ cfg.finalPackage ];
	xdg.configFile."xonsh/rc.xsh" = {
	enable = cfg.xonshrc != "";
	text = cfg.xonshrc;
	};

Another option is how #5160 does it: split by files. It's directly supported by xonsh.

Which one is better? I don't know, but you and @inmaldrerah should probably join efforts.

Thanks both!

[inmaldrerah]

This xdg.configFile."xonsh/rc.xsh" entry should be in the previous config block.

[drmikecrowe]

@pasqui23 -- I'm confused how this PR and NixOS/nixpkgs#241386 will interact. Are you and @greg-hellings communicating? Will these work together?

I want this support in home-manager, but I feel like we need the xontribs to be in nixpkgs, not inline in the home-manager like this.

FWIW, I'm trying to maintain a NUR of the xontribs I find that we can migrate to nixpkgs -- these should be in the PR referenced above

[pasqui23]

On 20/07/24 19:14, drmikecrowe ***@***.***> wrote: @pasqui23 <https://github.com/pasqui23> -- I'm confused how this PR and NixOS/nixpkgs#241386 <NixOS/nixpkgs#241386> will interact. Are you and @greg-hellings <https://github.com/greg-hellings> communicating? Will these work together? I want this support in home-manager, but I feel like we need the xontribs to be in nixpkgs, not inline in the home-manager like this. FWIW, I'm /trying/ to maintain a NUR of the xontribs I find that we can migrate to nixpkgs -- these /should/ be in the PR referenced above — Reply to this email directly, view it on GitHub <#5494 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABU4KH6PPRXULIR5KXAVJDTZNKLFXAVCNFSM6AAAAABIXMU72WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBRGIZDSNJZHA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

No I wasn't aware of @greg-hellings work. I will take a look at it later

[greg-hellings]

This is probably not the way to do this. I don't know if home-manager allows it, but cramming it in here manually seems less than ideal.

[pasqui23]

On 23/08/24 20:38, Greg Hellings ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------------------------------------------------ In modules/programs/broot.nix <https://github.com/nix-community/home- manager/pull/5494#discussion_r1729379160>: > @@ -237,5 +245,27 @@ in { programs.nushell.extraConfig = mkIf cfg.enableNushellIntegration (shellInit "nushell"); + + programs.xonsh = mkIf cfg.enableXonshIntegration { + xonshrc = "xontrib load broot"; + extraPackages = ps: + [ + (ps.buildPythonPackage { This is probably not the way to do this. I don't know if home-manager allows it, but cramming it in here manually seems less than ideal. — Reply to this email directly, view it on GitHub <https://github.com/nix- community/home-manager/pull/5494#pullrequestreview-2257867607>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ ABU4KH75DYBWTXYWLZ2NRCTZS56TZAVCNFSM6AAAAABIXMU72WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENJXHA3DONRQG4>. You are receiving this because you were mentioned.Message ID: <nix- ***@***.***>

Why would it be suboptimal?

[pasqui23]

Wait now I see it. Yeah I can't seem to make it work unfortunately and NixOS/nixpkgs#241386 doesn't seem to add it in upstream either

[pasqui23]

Put this as wip until NixOS/nixpkgs#241386 is merged and I can use xonsh-direnv from it

[stale]

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

• GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
• If it is unfinished but you plan to finish it, please mark it as a draft.
• If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
• To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

• If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

[Infinidoge]

I've made a new PR (shown above) that adds the xontribs. If you all can review it to try and get it merged, that would be appreciated.