Code

Hash change guards#698

Code

Merged

tclose merged 30 commits intonipype:masternipype/pydra:masterfrom tclose:hash-change-guardstclose/pydra:hash-change-guardsCopy head branch name to clipboardMar 8, 2024

+286-92

Commits

Commits on Feb 24, 2024

• Implemented hash-change guards in TaskBase._run()

  tclose

  committed
  3a72666

• added hash guards to workflow execution (i.e. on workflow inputs)

  tclose

  committed
  b378f83

• reworked error message for blocked upstream tasks to specifiy which tasks are blocked by referencing Workflow.inputs._graph_checksums. Reworked blocked tasks unittest so that it now raises an error…

  Show description for 5aaf62f
  tclose

  committed
  5aaf62f

• touched up messages for hash change errors

  tclose

  committed
  0397a18

• replaced attrs.evolve with manual setattr of inputs within Task._run() in order to retain hidden _hashes member used to provided detailed information on any inadvertant hash changes pre/post run

  tclose

  committed
  1d77f4b

• updated explicit hashes in unittests to match new values produced by altered spec.hash() function

  tclose

  committed
  e2d009b

• added a sleep to alter_x to make sure it runs after identity

  tclose

  committed
  48d68f5

• fix up

  tclose

  committed
  1a9eed0

• [skip ci] updates comment

  tclose

  committed
  d76bb3d

• upped sleep

  tclose

  committed
  6e1f030

• added random in to ensure that alter_x finishes after identity

  tclose

  committed
  6717d85

• added more reruns to test_hash_changes_in_workflow_graph

  tclose

  committed
  1cd9491

• fixed bugs in graph hash error test

  tclose

  committed
  7d6849b

• added logging to assist in tracking down hashing issues

  tclose

  committed
  df9ecc6

• [skip ci] touched up error message

  tclose

  committed
  930dfc1

• added docstring to bytes_repr to retrigger checks

  tclose

  committed
  6128951

• updated bytes_repr doc string

  tclose

  committed
  4ba8da0

• removed check for result None in TaskBase._run(). Shouldn't occur now that hash changes are being detected

  tclose

  committed
  15a775d

• added test to hit unstable hash check branch

  tclose

  committed
  1263f5a

• expanded hash graph error message to include final values/hashes of problematic nodes

  tclose

  committed
  b54166e

• More touch ups to error messages

  tclose

  committed
  048c0a1

• Update pydra/engine/tests/test_submitter.py

  Show description for c282d3e
  

  tclose

  and

  effigies

  committed
  c282d3e

• Update pydra/engine/tests/test_submitter.py

  Show description for 509afc7
  

  tclose

  and

  effigies

  committed
  509afc7

• reworked hash change detection error messages

  tclose

  committed
  6e91065

• modified modified inputs so it returns the actual original inputs not a deepcopy as for some poorly behaved objects the hash of the deepcopy can be different

  tclose

  committed
  9896735

• changed deepcopy to copy in checksum_states (not sure whether this is ok)

  tclose

  committed
  e660351

• changed test_hash_changes unittest so it works with python 3.8

  tclose

  committed
  8a5541c

• changed _graph_checksums to a dict instead of a list

  tclose

  committed
  4e1d4a8

Commits on Mar 2, 2024

• Merge branch 'master' into hash-change-guards

  tclose

  authored
  b94f185

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for ff281aa
  pre-commit-ci[bot]

  committed
  ff281aa