Carousel #49
Merged
Carousel #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danimoh
force-pushed
the
daniel/carousel
branch
5 times, most recently
from
d5d2106 to
4737109
Compare
|
I now moved the Tweenable to nimiq-utils. |
danimoh
force-pushed
the
daniel/carousel
branch
from
c9437fe to
2639b2a
Compare
danimoh
force-pushed
the
daniel/carousel
branch
from
2639b2a to
973e15e
Compare
sisou
requested changes
Oct 22, 2019
Merged
nibhar
requested changes
Nov 21, 2019
sisou
force-pushed
the
daniel/carousel
branch
from
973e15e to
0c4b0d6
Compare
Calculate min-height as height of the largest entry such that the entry fits into the component when it's in the front. To calculate the required carousel width, we would need to perspectively scale the distance between the points where the perspective rays starting at the user meet the circle (with increased radius accounting for the entry widths) as tangents. We're not currently doing this.
- Refactored as multiple methods can't watch the same property (resulting in watchers defined first getting overwritten) - unified selection update into one method - fix a bug that a change of entries prop resulted in switching to entries[0] even if effectiveSelectedEntry was different - optimize update order (saves one rendering with intermediary values)
- rephrase some comments - add a comment why we can't use transform-style: preserve-3d - use array.includes - specify function parameter types - return early in _shouldHide if no entries should be hidden
danimoh
force-pushed
the
daniel/carousel
branch
from
cd3c845 to
d8314c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works fine so far. Some things could still be improved which has not been done so far:
0a59736)