Explicitly export icons from main.ts #33
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now different builds trageting different apps can chose which icons to include in main.ts instead of in Icons.vue. By not affecting the exports in Icons.vue, the build process (probably the linter only) will not complain about missing exports anymore when checking files in the folder structure that are not actually part of the build but still checked for some reason.
danimoh
force-pushed
the
master
branch
2 times, most recently
from
2b462fb to
e64b89b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now just keeping this here for reference.
The idea was that now different builds trageting different apps can chose which icons to include in main.ts instead of in Icons.vue.
By not affecting the exports in Icons.vue, the build process (probably the linter only) would not complain
about missing exports anymore when checking files in the folder structure that are not actually part of the build but still checked for some reason.
However, unfortunately the icons that were commented out in
main.tsstill ended up in the bundle.I experimented with setting
sideEffectsfalse onvue-componentsandnimiq-styleand investigated whether the icons are bundled due to the call of theIconBasemixin.However, the icons are bundled regardless of the
sideEffectsflag and omitting theIconBasemixin.Note that this, fix should not be necessary anymore once we actually work on #8.