Ensure transactions in past election blocks can be proven #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viquezclaudio
approved these changes
Dec 17, 2024
|
Since election blocks do not contain regular transactions, you mean the problem was related to prove inherents/rewards in election blocks? |
|
Yes, but they are handled and logged like any other transaction as far as the web-client is concerned. |
Before this change, transactions in election blocks where tried to be proven with the block number of the following election block, because `Policy::election_block_after()` returns the following election block if given an election block number.
jsdanielh
force-pushed
the
soeren/election-block-txs-proofs
branch
from
f0a7c85 to
e067731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, transactions in election blocks where tried to be proven with the block number of the following election block, because
Policy::election_block_after()returns the following election block if given an election block number.This addresses the latest finding in #3200.
Pull request checklist
clippyandrustfmtwarnings.