RPC Server: handle create_basic_transaction_with_data method hex decoding errors gracefully
#3198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisou
approved these changes
Dec 16, 2024
…coding errors gracefully
jsdanielh
force-pushed
the
stefan/panic-create-txn-panic
branch
from
367aacf to
f5ef915
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Instead of panicking during a failed hex decoding, gracefully handle the error.
Properly informing the consumer that a hex representation is expected will be part of different PR.
This fixes #3197.
Pull request checklist
clippyandrustfmtwarnings.