Correct web-client vesting contract data parsing #3177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now takes the transaction's actual recipient data, instead of the internal representation of a vesting contract's `CreationTransactionData`. The internal representation uses `varints` for the serialization of the contract's `startTime` and `timeStep`, but the transaction recipient data doesn't. Since the transaction recipient data also has formats that doesn't include the contracts `totalAmount`, this field is required now to be passed to the parsing method.
jsdanielh
force-pushed
the
soeren/web-vesting-parse-data
branch
from
4719bdf to
d1e070a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now takes the transaction's actual recipient data, instead of the internal representation of a vesting contract's
CreationTransactionData. The internal representation usesvarintsto serialize the contract'sstartTimeandtimeStep, but the on-chain transaction recipient data doesn't. Since the transaction recipient data also has shorter formats that don't include the contract'stotalAmount, this field is required now to be passed to the parsing method.Pull request checklist
clippyandrustfmtwarnings.