Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing clippy warnings #3168

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fixing clippy warnings #3168

merged 1 commit into from
Dec 5, 2024

Conversation

ii-cruz
Copy link
Member

@ii-cruz ii-cruz commented Nov 28, 2024

What's in this pull request?

Fixing clippy warnings.

#3165 fixes the metrics server error, so this PR doesn't address it.

Pull request checklist

  • All tests pass. The project builds and runs.
  • I have resolved any merge conflicts.
  • I have resolved all clippy and rustfmt warnings.

@ii-cruz ii-cruz added the enhancement New feature or request label Nov 28, 2024
@ii-cruz ii-cruz self-assigned this Nov 28, 2024
metrics-server/src/lib.rs Outdated Show resolved Hide resolved
@ii-cruz ii-cruz force-pushed the iicruz/clippy-warnings-fix branch 6 times, most recently from 672adb1 to 2117f46 Compare December 4, 2024 20:53
@ii-cruz ii-cruz force-pushed the iicruz/clippy-warnings-fix branch from 2117f46 to 4fa5fb2 Compare December 5, 2024 15:22
Copy link
Member

@jsdanielh jsdanielh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsdanielh jsdanielh merged commit 4fa5fb2 into albatross Dec 5, 2024
8 checks passed
@jsdanielh jsdanielh deleted the iicruz/clippy-warnings-fix branch December 5, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants