[#560] [Chore] Improve iOS Template Maker #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markgravity
requested review from
suho,
blyscuit,
minhnimble,
nmint8m,
phongvhd93,
vnntsu,
ducbm051291,
Shayokh144,
Thieurom and
nkhanh44
as code owners
markgravity
force-pushed
the
chore/560-improve-ios-template-maker
branch
from
7bf00ff to
ef25e47
Compare
markgravity
changed the title
markgravity
force-pushed
the
chore/560-improve-ios-template-maker
branch
from
ef25e47 to
469a83d
Compare
markgravity
force-pushed
the
chore/560-improve-ios-template-maker
branch
2 times, most recently
from
5d62ddd to
0e00524
Compare
phongvhd93
reviewed
Jul 22, 2024
Scripts/Swift/iOSTemplateMaker/Sources/iOSTemplateMaker/SetUpCICDService.swift
Outdated
Show resolved
Hide resolved
Scripts/Swift/iOSTemplateMaker/Sources/iOSTemplateMaker/Helpers/Terminal.swift
Show resolved
Hide resolved
Scripts/Swift/iOSTemplateMaker/Sources/iOSTemplateMaker/Helpers/Terminal.swift
Outdated
Show resolved
Hide resolved
Scripts/Swift/iOSTemplateMaker/Sources/iOSTemplateMaker/SetUpCICDService.swift
Outdated
Show resolved
Hide resolved
Base automatically changed from
feature/546-add-support-to-adding-new-devices-directly-from-github-actions
to
develop
August 7, 2024 02:09
markgravity
force-pushed
the
chore/560-improve-ios-template-maker
branch
from
76ef2aa to
5d7cb8c
Compare
phongvhd93
approved these changes
Aug 12, 2024
|
@markgravity I tried to run but got this error unexpectedly found nil, do you face this one too? 🤔 
|
|
@nkhanh44 let me check 🙏 |
ducbm051291
approved these changes
Sep 24, 2024
@nkhanh44 it works normally on my end, so I will need more context from your side to reproduce it 🙏
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened 👀
ask(),confirm(),picker,step&write()...SetUpclasses to use new support functionsInsight 📝
n/a
Proof Of Work 📹