Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gh315] Support Phoenix 1.7.x #318

Draft
wants to merge 51 commits into
base: develop
Choose a base branch
from
Draft

[gh315] Support Phoenix 1.7.x #318

wants to merge 51 commits into from

Conversation

andyduong1920
Copy link
Member

@andyduong1920 andyduong1920 commented Feb 27, 2023 •
edited
Loading

closes https://github.com/nimblehq/elixir-templates/issues/gh315

What happened 👀

Support Phoenix 1.7.1

Insight 📝

The template could be applied to the Phoenix 1.7.1 project now. The newly generated app's codebase is falling, aside from that, we have disabled some addons, we will need to enable them again

  • Enable the Bootstrap addon -> The Bootstrap addon will remove all pre config TailwindCSS
  • Enable the ErrorView addon for API as the View is changed in Phoenix 1.7.1 -> Need to visit the new View system in Phoenix 1.7
  • Enable the SVGIcon -> Use the Veririef route structure handled by Liam in Change use of Router.Helpers to VerifiedRoutes #320

Proof Of Work 📹

The CI is passed

@andyduong1920 andyduong1920 added this to the 4.7.0 milestone Feb 27, 2023
@andyduong1920 andyduong1920 self-assigned this Feb 27, 2023
Base automatically changed from chore/upgrade-stack-versions to develop March 10, 2023 06:35
@andyduong1920 andyduong1920 force-pushed the feature/gh315-support-1.7.x branch from fb5d81b to 095cca8 Compare March 10, 2023 06:37
@andyduong1920 andyduong1920 force-pushed the feature/gh315-support-1.7.x branch from f402949 to 898d053 Compare March 10, 2023 07:42
@andyduong1920 andyduong1920 changed the title [gh315] Upgrade the template dependencies and Phoenix to 1.7.0 [gh315] Support Phoenix 1.7.x Mar 10, 2023
@andyduong1920 andyduong1920 force-pushed the feature/gh315-support-1.7.x branch from 0ff5849 to d91d395 Compare March 15, 2023 15:53
@andyduong1920 andyduong1920 force-pushed the feature/gh315-support-1.7.x branch from 442b17c to ad453cc Compare March 15, 2023 16:32
andyduong1920 and others added 24 commits March 15, 2023 23:49
@andyduong1920
[gh315] Fix credo helper
87b59ce
@liamstevens111
Initial
0b73dc2
@liamstevens111
Remove duplicate code introduced
f8225ad
@liamstevens111
Change IconHelper tests to pipe |> syntax
47bdea3
@andyduong1920
Merge pull request #320 from nimblehq/feature/incorporate-verified-ro…
25fd192 
…utes

Change use of Router.Helpers to VerifiedRoutes
@liamstevens111
Initial conversion from ErrorView to ErrorJSON view
614792e
@liamstevens111
Change to match pre-existing custom error output and tests
a9d9325
@liamstevens111
Add Plug.Conn.Status alias
9baa1c5
@liamstevens111
Add test for non-exisitant error code
4a0c259
@liamstevens111
Include changeset error output and tests
3e26ff0
@liamstevens111
Disable singlemodulefile CompassCredoCheck for test file
b496595
@liamstevens111
Add test for ensuring file exists for ErrorJSON in template
d9a3c6c
@liamstevens111
Fix webmodule name for Gettext
116856a
@liamstevens111
Add ErrorJSON to multiple module disable rule
2bd1e00
@liamstevens111
Use translate_error/1 from CoreComponents instead of redefining
33b9e63
@liamstevens111
Change to use ErrorJSON in Fallback Controller and check_empty_body_p…
c725541 
…arams_plug
@liamstevens111
Fix CoreComponent webmodule prefix for translate
4e7621b
@liamstevens111
Fix CoreComponent import again
2887ee6
@liamstevens111
Add back translate_errors as CoreComponents cant be found
31aea20
@liamstevens111
Update ViewCase although it doesn't seem to be used
8d6bb13
@liamstevens111
Update ViewCase although it doesn't seem to be used
d408554
@liamstevens111
Remove TODO and RouteHelper from feature_case and view_case
334c0da
@liamstevens111
Remove RouteHelper from tests
dece778
@andyduong1920
Merge pull request #323 from nimblehq/feature/revisit-error-view
0fc9f5a 
Convert from ErrorView to new ErrorJSON view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byhbt byhbt Awaiting requested review from byhbt byhbt will be requested when the pull request is marked ready for review byhbt is a code owner

@bterone bterone Awaiting requested review from bterone bterone will be requested when the pull request is marked ready for review bterone is a code owner

@longnd longnd Awaiting requested review from longnd longnd will be requested when the pull request is marked ready for review longnd is a code owner

@Nihisil Nihisil Awaiting requested review from Nihisil Nihisil will be requested when the pull request is marked ready for review Nihisil is a code owner

@nvminhtue nvminhtue Awaiting requested review from nvminhtue nvminhtue will be requested when the pull request is marked ready for review nvminhtue is a code owner

@liamstevens111 liamstevens111 Awaiting requested review from liamstevens111 liamstevens111 will be requested when the pull request is marked ready for review liamstevens111 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@andyduong1920 andyduong1920

Labels
priority : high type : feature
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@andyduong1920 @liamstevens111