Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#490] Add release note for Codemagic CD workflow #558

Merged
merged 7 commits into from
Mar 21, 2024

Conversation

lydiasama
Copy link
Contributor

@lydiasama lydiasama commented Nov 9, 2023

What happened 👀

Add command line script to get the commit message to show as the release note on Codemagic CD workflow

Insight 📝

  • For Staging, we use the latest merge commit message
  • For Production, we use the latest 50 merge commit messages from the last tag.

Proof Of Work 📹

Staging:

Screenshot 2566-11-09 at 4 56 22 PM

Note

We need to merge this change to main first to see the release note on the Firebase App Distribution.
But as I test the script, it works correctly in the following image:

Screenshot 2566-11-10 at 11 09 46 AM

Copy link

github-actions bot commented Nov 9, 2023

1 Warning
⚠️ Uh oh! Your project is under 80% coverage!

Kover report for template-compose:

🧛 Template - Compose Unit Tests Code Coverage: 61.57%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

codemagic.yaml
codemagic.yaml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@lydiasama lydiasama force-pushed the chore/490-add-release-note-for-codemagic-cd branch from e93b1cd to 2e88e1e Compare November 10, 2023 03:54
@lydiasama lydiasama force-pushed the chore/490-add-release-note-for-codemagic-cd branch from 448a4e4 to 3efdd7f Compare November 10, 2023 04:16
@lydiasama lydiasama marked this pull request as ready for review November 10, 2023 04:21
Comment on lines +93 to +94
groups:
- firebase_credentials
Copy link
Contributor Author

@lydiasama lydiasama Nov 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add the environment groups here again. It seems to add the environments > vars above overrides the environment that we imported from configure_environment

@ryan-conway ryan-conway added this to the 3.27.0 milestone Dec 1, 2023
@lydiasama lydiasama force-pushed the chore/490-add-release-note-for-codemagic-cd branch from 3b1202a to 922f7b9 Compare March 11, 2024 08:25
@lydiasama lydiasama temporarily deployed to template-compose March 11, 2024 08:25 — with GitHub Actions Inactive
@lydiasama lydiasama temporarily deployed to template-compose March 11, 2024 11:27 — with GitHub Actions Inactive
@lydiasama lydiasama requested a review from AVI5HEK March 11, 2024 11:27
@lydiasama
Copy link
Contributor Author

All Updated 🚀 @chornerman @AVI5HEK

@ryan-conway ryan-conway merged commit 4e56383 into develop Mar 21, 2024
4 checks passed
@ryan-conway ryan-conway deleted the chore/490-add-release-note-for-codemagic-cd branch March 21, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codemagic: Generate and add "release notes" when distributing new builds on Firebase (staging and production)
4 participants