Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#462] Update GitHub workflows to use concurrency #546

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

kaungkhantsoe
Copy link
Contributor

@kaungkhantsoe kaungkhantsoe commented Oct 23, 2023

What happened 👀

The cancel-workflow action added a warning on their README that GitHub now supports concurrency and this workflow might not be needed anymore.

Resource: https://docs.github.com/en/actions/using-jobs/using-concurrency
Sample implementation: nimblehq/rails-templates#398

Insight 📝

Add concurrency for all workflows except the following 2:

  • .github/workflows/publish_docs_to_wiki
  • .cicdtemplate/.github/workflows/deploy_staging_and_production_to_firebase_app_distribution.yml

Proof Of Work 📹

Screenshot 2023-10-23 at 5 40 47 PM

@kaungkhantsoe kaungkhantsoe self-assigned this Oct 23, 2023
@kaungkhantsoe kaungkhantsoe temporarily deployed to template-compose October 23, 2023 09:51 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 23, 2023

1 Warning
⚠️ Uh oh! Your project is under 80% coverage!

Kover report for template-compose:

🧛 Template - Compose Unit Tests Code Coverage: 63.04%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

bump_version.yml
bump_version.yml
draft-new-release.yml
review_pull_request.yml
review_pull_request.yml
run_detekt_and_unit_tests.yml
run_detekt_and_unit_tests.yml
verify_newproject_script.yml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@ryan-conway ryan-conway merged commit 7a75d19 into develop Oct 25, 2023
5 of 6 checks passed
@ryan-conway ryan-conway deleted the feature/462-add-support-for-concurrency-cicd branch October 25, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GitHub workflows to use concurrency
4 participants