-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#515] [KMM Support] Refactor package names #511
[#515] [KMM Support] Refactor package names #511
Conversation
Kover report for template-xml:🧛 Template - XML Unit Tests Code Coverage:
|
File | Coverage |
---|---|
ApiServiceProvider.kt |
0.00% |
AppPreferencesRepositoryImpl.kt |
100.00% |
BaseSharedPreferences.kt |
0.00% |
ConverterFactoryProvider.kt |
0.00% |
EncryptedSharedPreferences.kt |
0.00% |
Error.kt |
100.00% |
ErrorResponse.kt |
100.00% |
Exceptions.kt |
100.00% |
HomeViewModel.kt |
0.00% |
Model.kt |
100.00% |
MoshiBuilderProvider.kt |
100.00% |
RepositoryImpl.kt |
100.00% |
Response.kt |
100.00% |
ResponseMapping.kt |
89.68% |
RetrofitProvider.kt |
0.00% |
SharedPreferencesExt.kt |
0.00% |
UiModel.kt |
0.00% |
UseCase.kt |
100.00% |
Modified Files Not Found In Coverage Report:
.keep
ApiService.kt
AppPreferencesRepository.kt
AppPreferencesRepositoryImplTest.kt
HomeScreen.kt
HomeScreenTest.kt
HomeViewModelTest.kt
MockUtil.kt
MockUtil.kt
MockUtil.kt
MoshiModule.kt
PreferencesModule.kt
Repository.kt
RepositoryModule.kt
RepositoryTest.kt
ResponseMappingTest.kt
RetrofitModule.kt
StorageModule.kt
UseCaseTest.kt
proguard-rules.pro
Codebase cunningly covered by count Shroud 🧛
Kover report for template-compose:
🧛 Template - Compose Unit Tests Code Coverage: 62.07%
Coverage of Modified Files:
File | Coverage |
---|---|
ApiServiceProvider.kt |
0.00% |
AppPreferencesRepositoryImpl.kt |
100.00% |
BaseSharedPreferences.kt |
0.00% |
ConverterFactoryProvider.kt |
0.00% |
EncryptedSharedPreferences.kt |
0.00% |
Error.kt |
100.00% |
ErrorResponse.kt |
100.00% |
Exceptions.kt |
100.00% |
HomeScreen.kt |
64.06% |
HomeViewModel.kt |
100.00% |
Model.kt |
100.00% |
MoshiBuilderProvider.kt |
100.00% |
RepositoryImpl.kt |
100.00% |
Response.kt |
100.00% |
ResponseMapping.kt |
90.85% |
RetrofitProvider.kt |
0.00% |
SharedPreferencesExt.kt |
0.00% |
UiModel.kt |
84.21% |
UseCase.kt |
100.00% |
Modified Files Not Found In Coverage Report:
.keep
ApiService.kt
AppPreferencesRepository.kt
AppPreferencesRepositoryImplTest.kt
HomeScreenTest.kt
HomeViewModelTest.kt
MockUtil.kt
MockUtil.kt
MockUtil.kt
MoshiModule.kt
PreferencesModule.kt
Repository.kt
RepositoryModule.kt
RepositoryTest.kt
ResponseMappingTest.kt
RetrofitModule.kt
StorageModule.kt
UseCaseTest.kt
proguard-rules.pro
Codebase cunningly covered by count Shroud 🧛
Generated by 🚫 Danger
0785455
to
cb097ec
Compare
ce085dd
to
4def9ea
Compare
cb097ec
to
ee6bab7
Compare
Closes #515
What happened 👀
homogeneous contents
.heterogeneous contents
.Insight 📝
As we're mixing between singular and plural in our codebase. I see the benefit and purpose of using plurals to explicit that the package contains multiple classes of the same type. Checking out some sample projects around, we can see this point of plural naming usage:
After researching, I found this best practice that could be applied to our template:
homogeneous contents
.heterogeneous contents
.https://softwareengineering.stackexchange.com/questions/75919/should-package-names-be-singular-or-plural
For example,
Proof Of Work 📹
The app works properly after migrating.