[#513] [KMM Support] Migrate to Gradle 8 #508

luongvo · 2023-08-22T10:43:41Z

Closes #513

What happened 👀

Migrate to
- Gradle 8.1.2 https://mvnrepository.com/artifact/com.android.application/com.android.application.gradle.plugin?repo=google
- Kotlin 1.9.10 https://github.com/JetBrains/kotlin/releases
- Compose BOM 2023.09.02 https://mvnrepository.com/artifact/androidx.compose/compose-bom
- SDK 34 https://issuetracker.google.com/issues/295457468 and https://developer.android.com/about/versions/14/behavior-changes-all
- Compile with JDK 17.
Apply new updates when initializing a new project by AS with AGP 8.
Use Java 17 in workflows for the new template-compose.

Insight 📝

All build plugin versions are defined from the root build.gradle.
There are a new pluginManagement and dependencyResolutionManagement blocks from the root settings.gradle.
Skip android.enableJetifier=true flag, as most dependencies are now written for AndroidX.
Gradle 8 does not generate the BuildConfig class anymore 👉 temporarily enables to optimize in a separate class.

There are some new issues when switching to compile with JDK 17 (which has been listing here https://qiita.com/Nabe1216/items/05c9981fd12eb2fa1df0):

R8: Missing class java.lang.invoke.StringConcatFactory
```
ERROR: R8: Missing class java.lang.invoke.StringConcatFactory (referenced from: java.lang.String co.nimblehq.template.compose.data.response.ErrorResponse.toString() and 1 other context)
```
👉 To solve this, we can suppress this warning by adding a proguard rule -dontwarn java.lang.invoke.StringConcatFactory in the data module ✅

R8: Missing classes from org.bouncycastle, org.conscrypt and org.openjsse

ERROR: R8: Missing class org.bouncycastle.jsse.BCSSLParameters (referenced from: void okhttp3.internal.platform.BouncyCastlePlatform.configureTlsExtensions(javax.net.ssl.SSLSocket, java.lang.String, java.util.List) and 1 other context)
Missing class org.bouncycastle.jsse.BCSSLSocket (referenced from: void okhttp3.internal.platform.BouncyCastlePlatform.configureTlsExtensions(javax.net.ssl.SSLSocket, java.lang.String, java.util.List) and 5 other contexts)
Missing class org.bouncycastle.jsse.provider.BouncyCastleJsseProvider (referenced from: void okhttp3.internal.platform.BouncyCastlePlatform.<init>())
Missing class org.conscrypt.Conscrypt$Version (referenced from: boolean okhttp3.internal.platform.ConscryptPlatform$Companion.atLeastVersion(int, int, int))
Missing class org.conscrypt.Conscrypt (referenced from: boolean okhttp3.internal.platform.ConscryptPlatform$Companion.atLeastVersion(int, int, int) and 4 other contexts)
Missing class org.conscrypt.ConscryptHostnameVerifier (referenced from: okhttp3.internal.platform.ConscryptPlatform$DisabledHostnameVerifier)
Missing class org.openjsse.javax.net.ssl.SSLParameters (referenced from: void okhttp3.internal.platform.OpenJSSEPlatform.configureTlsExtensions(javax.net.ssl.SSLSocket, java.lang.String, java.util.List))
Missing class org.openjsse.javax.net.ssl.SSLSocket (referenced from: void okhttp3.internal.platform.OpenJSSEPlatform.configureTlsExtensions(javax.net.ssl.SSLSocket, java.lang.String, java.util.List) and 1 other context)
Missing class org.openjsse.net.ssl.OpenJSSE (referenced from: void okhttp3.internal.platform.OpenJSSEPlatform.<init>())

👉 To solve this, adding these proguard rules in the app module

-dontwarn okhttp3.internal.platform.**
-dontwarn org.conscrypt.**
-dontwarn org.bouncycastle.**
-dontwarn org.openjsse.**

Or upgrade OkHttp to version 4.11.0 to get the default added proguard rules from the dependency ✅

Proof Of Work 📹

The app works properly after migrating: both debug and release builds.

References

github-actions · 2023-08-22T11:04:17Z

	1 Warning
⚠️	Uh oh! Your project is under 80% coverage!

Kover report for template-xml:

🧛 Template - XML Unit Tests Code Coverage: `34.25%`

Coverage of Modified Files:

File	Coverage

Modified Files Not Found In Coverage Report:

AndroidManifest.xml
AndroidManifest.xml
AndroidManifest.xml
Plugins.kt
Versions.kt
backup_rules.xml
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
consumer-rules.pro
data_extraction_rules.xml
deploy_staging_and_production_to_firebase_app_distribution.yml
gradle-wrapper.jar
gradle-wrapper.properties
gradle.properties
gradlew.bat
ic_launcher.webp
ic_launcher.webp
ic_launcher.webp
ic_launcher.webp
ic_launcher.webp
ic_launcher.xml
ic_launcher_background.xml
ic_launcher_foreground.xml
ic_launcher_round.webp
ic_launcher_round.webp
ic_launcher_round.webp
ic_launcher_round.webp
ic_launcher_round.webp
ic_launcher_round.xml
new_project.kts
proguard-rules.pro
review_pull_request.yml
review_pull_request.yml
run_detekt_and_unit_tests.yml
run_detekt_and_unit_tests.yml
settings.gradle.kts
themes.xml
verify_newproject_script.yml

Codebase cunningly covered by count Shroud 🧛

Kover report for template-compose:

🧛 Template - Compose Unit Tests Code Coverage: `62.05%`

Coverage of Modified Files:

File	Coverage

Modified Files Not Found In Coverage Report:

AndroidManifest.xml
AndroidManifest.xml
AndroidManifest.xml
Plugins.kt
Versions.kt
backup_rules.xml
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
consumer-rules.pro
data_extraction_rules.xml
deploy_staging_and_production_to_firebase_app_distribution.yml
gradle-wrapper.jar
gradle-wrapper.properties
gradle.properties
gradlew.bat
ic_launcher.webp
ic_launcher.webp
ic_launcher.webp
ic_launcher.webp
ic_launcher.webp
ic_launcher.xml
ic_launcher_background.xml
ic_launcher_foreground.xml
ic_launcher_round.webp
ic_launcher_round.webp
ic_launcher_round.webp
ic_launcher_round.webp
ic_launcher_round.webp
ic_launcher_round.xml
new_project.kts
proguard-rules.pro
review_pull_request.yml
review_pull_request.yml
run_detekt_and_unit_tests.yml
run_detekt_and_unit_tests.yml
settings.gradle.kts
themes.xml
verify_newproject_script.yml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

template-compose/app/src/main/res/xml/backup_rules.xml

template-compose/app/src/main/res/xml/data_extraction_rules.xml

template-compose/data/consumer-rules.pro

github-actions · 2023-08-23T08:43:26Z

template-compose/app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml

@@ -2,4 +2,5 @@
 <adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android">


⚠️ The application adaptive icon is missing a monochrome tag

False-negative warning? 🤔

@lydiasama monochrome is a new feature of Adaptive Icon from API 33. It's default generated from the new project by AS as that is to prepare for the support 🤷‍♂️

template-compose/app/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml

scripts/new_project.kts

lydiasama · 2023-09-07T03:24:23Z

.github/workflows/review_pull_request.yml

Can we remove the Cache gems step and set the bundler-cache: true at Set up Ruby step like we did in KMM Templates?

@lydiasama Yes, but it's out of this PR's scope. I recommend revising this workflow from this task instead #519.

template-compose/app/build.gradle.kts

lydiasama · 2023-09-07T03:31:31Z

template-compose/app/build.gradle.kts

    buildTypes {
-        getByName(BuildTypes.RELEASE) {
+        release {


Why do we need to update this? 🤔

@lydiasama release { is a new supported block from Gradle 8's DSL. We should use any built-in features instead of manual configurations 🤓

lydiasama · 2023-09-07T03:36:57Z

template-compose/app/src/main/AndroidManifest.xml

        android:icon="@mipmap/ic_launcher"
        android:label="@string/app_name"
        android:networkSecurityConfig="@xml/network_security_config"
        android:roundIcon="@mipmap/ic_launcher_round"
        android:supportsRtl="true"
-        android:theme="@style/AppTheme">
+        android:theme="@style/AppTheme"
+        tools:targetApi="31">


May I know the purpose of this tools:targetApi="31"? 🙏🏻

@lydiasama To bypass this warning, it explains the dataExtractionRules attr is used on API 31 only and will be ignored on lower APIs. The tools:targetApi="31" is default generated for the new project by AS with Gradle 8.

.github/workflows/review_pull_request.yml

.github/workflows/run_detekt_and_unit_tests.yml

.github/workflows/verify_newproject_script.yml

manh-t

Good work 👏

template-compose/buildSrc/src/main/java/Versions.kt

doannimble

The rest lgtm

.github/workflows/review_pull_request.yml

.github/workflows/verify_newproject_script.yml

…, and SDK 34

doannimble

lgtm now 🚀

luongvo added the type : feature label Aug 22, 2023

luongvo self-assigned this Aug 22, 2023

luongvo had a problem deploying to template-compose August 22, 2023 10:43 — with GitHub Actions Failure

luongvo had a problem deploying to template-compose August 22, 2023 10:53 — with GitHub Actions Error

luongvo temporarily deployed to template-compose August 22, 2023 10:54 — with GitHub Actions Inactive

luongvo temporarily deployed to template-compose August 22, 2023 11:15 — with GitHub Actions Inactive

luongvo temporarily deployed to template-compose August 23, 2023 04:14 — with GitHub Actions Inactive

luongvo temporarily deployed to template-compose August 23, 2023 04:15 — with GitHub Actions Inactive

luongvo temporarily deployed to template-compose August 23, 2023 07:28 — with GitHub Actions Inactive

luongvo temporarily deployed to template-compose August 23, 2023 07:32 — with GitHub Actions Inactive

luongvo commented Aug 23, 2023

View reviewed changes

template-compose/app/src/main/res/xml/backup_rules.xml Outdated Show resolved Hide resolved

luongvo commented Aug 23, 2023

View reviewed changes

template-compose/app/src/main/res/xml/data_extraction_rules.xml Outdated Show resolved Hide resolved

luongvo commented Aug 23, 2023

View reviewed changes

template-compose/data/consumer-rules.pro Outdated Show resolved Hide resolved

luongvo temporarily deployed to template-compose August 23, 2023 08:34 — with GitHub Actions Inactive

github-actions bot reviewed Aug 23, 2023

View reviewed changes

template-compose/app/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml Show resolved Hide resolved

luongvo temporarily deployed to template-compose August 23, 2023 08:55 — with GitHub Actions Inactive

luongvo temporarily deployed to template-compose August 23, 2023 09:13 — with GitHub Actions Inactive

luongvo mentioned this pull request Aug 24, 2023

[#13] [Part 2] Implement the base Clean Architecture with MVVM: data and domain layer nimblehq/kmm-templates#37

Merged

3 tasks

luongvo force-pushed the feature/kmm-support-upgrade-to-gradle-8 branch from 5c675b7 to d1a6dd2 Compare August 25, 2023 03:57

luongvo temporarily deployed to template-compose August 25, 2023 03:58 — with GitHub Actions Inactive

luongvo temporarily deployed to template-compose August 29, 2023 15:21 — with GitHub Actions Inactive

luongvo changed the title ~~[KMM Support] Migrate to Gradle 8~~ [#513] [KMM Support] Migrate to Gradle 8 Aug 31, 2023

luongvo temporarily deployed to template-compose August 31, 2023 04:49 — with GitHub Actions Inactive

luongvo linked an issue Aug 31, 2023 that may be closed by this pull request

Upgrade to Gradle 8 and JDK 17 #513

Closed

luongvo added this to the 3.24.0 milestone Aug 31, 2023

luongvo requested review from thiennguyen0196, toby-thanathip and Wadeewee as code owners August 31, 2023 06:41

kaungkhantsoe reviewed Aug 31, 2023

View reviewed changes

scripts/new_project.kts Show resolved Hide resolved

lydiasama reviewed Sep 7, 2023

View reviewed changes

chornerman reviewed Sep 14, 2023

View reviewed changes

[#513] Upgrade some GA step versions

799ed77

luongvo temporarily deployed to template-compose September 18, 2023 11:05 — with GitHub Actions Inactive

luongvo requested review from kaungkhantsoe, chornerman and lydiasama September 18, 2023 11:05

chornerman approved these changes Sep 19, 2023

View reviewed changes

kaungkhantsoe approved these changes Sep 21, 2023

View reviewed changes

ryan-conway temporarily deployed to template-compose September 22, 2023 03:07 — with GitHub Actions Inactive

luongvo force-pushed the feature/kmm-support-upgrade-to-gradle-8 branch from 3b98ce2 to 799ed77 Compare September 22, 2023 03:55

luongvo temporarily deployed to template-compose September 22, 2023 03:55 — with GitHub Actions Inactive

manh-t reviewed Sep 27, 2023

View reviewed changes

template-compose/buildSrc/src/main/java/Versions.kt Outdated Show resolved Hide resolved

ryan-conway approved these changes Oct 2, 2023

View reviewed changes

doannimble reviewed Oct 2, 2023

View reviewed changes

.github/workflows/review_pull_request.yml Show resolved Hide resolved

.github/workflows/verify_newproject_script.yml Show resolved Hide resolved

[#513] Upgrade to Gradle 8.1.2, Kotlin 1.9.10, Compose BOM 2023.09.02…

d49e49f

…, and SDK 34

luongvo temporarily deployed to template-compose October 2, 2023 04:25 — with GitHub Actions Inactive

luongvo requested review from doannimble and manh-t October 2, 2023 04:27

doannimble approved these changes Oct 2, 2023

View reviewed changes

luongvo temporarily deployed to template-compose October 2, 2023 04:30 — with GitHub Actions Inactive

manh-t approved these changes Oct 2, 2023

View reviewed changes

Base automatically changed from feature/kmm-support-dependencies to develop October 2, 2023 05:08

ryan-conway temporarily deployed to template-compose October 2, 2023 05:08 — with GitHub Actions Inactive

ryan-conway merged commit 72a7df8 into develop Oct 2, 2023
4 checks passed

ryan-conway deleted the feature/kmm-support-upgrade-to-gradle-8 branch October 2, 2023 05:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#513] [KMM Support] Migrate to Gradle 8 #508

[#513] [KMM Support] Migrate to Gradle 8 #508

luongvo commented Aug 22, 2023 •

edited

Loading

github-actions bot commented Aug 22, 2023 •

edited

Loading

github-actions bot Aug 23, 2023

lydiasama Sep 7, 2023

luongvo Sep 18, 2023

lydiasama Sep 7, 2023

luongvo Sep 18, 2023

lydiasama Sep 7, 2023

luongvo Sep 18, 2023

lydiasama Sep 7, 2023

luongvo Sep 18, 2023

manh-t left a comment

doannimble left a comment

doannimble left a comment

		@@ -2,4 +2,5 @@
		<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android">

[#513] [KMM Support] Migrate to Gradle 8 #508

[#513] [KMM Support] Migrate to Gradle 8 #508

Conversation

luongvo commented Aug 22, 2023 • edited Loading

What happened 👀

Insight 📝

Proof Of Work 📹

References

github-actions bot commented Aug 22, 2023 • edited Loading

Kover report for template-xml:

🧛 Template - XML Unit Tests Code Coverage: 34.25%

Coverage of Modified Files:

Modified Files Not Found In Coverage Report:

Kover report for template-compose:

🧛 Template - Compose Unit Tests Code Coverage: 62.05%

Coverage of Modified Files:

Modified Files Not Found In Coverage Report:

github-actions bot Aug 23, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

manh-t left a comment

Choose a reason for hiding this comment

doannimble left a comment

Choose a reason for hiding this comment

doannimble left a comment

Choose a reason for hiding this comment

luongvo commented Aug 22, 2023 •

edited

Loading

github-actions bot commented Aug 22, 2023 •

edited

Loading

🧛 Template - XML Unit Tests Code Coverage: `34.25%`

🧛 Template - Compose Unit Tests Code Coverage: `62.05%`