Skip to content

Commit

Permalink
[#494] Replace danger-ruby with danger-kotlin
Browse files Browse the repository at this point in the history
  • Loading branch information
chornerman committed Aug 3, 2023
1 parent c6cc06d commit b971e0e
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 24 deletions.
25 changes: 1 addition & 24 deletions .github/workflows/review_pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,30 +69,7 @@ jobs:
working-directory: ./template-compose
run: ./gradlew koverMergedXmlReport

- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '2.7'

- name: Cache gems
uses: actions/cache@v2
with:
path: vendor/bundle
key: ${{ runner.os }}-gems-${{ hashFiles('**/Gemfile.lock') }}
restore-keys: |
${{ runner.os }}-gems-
- name: Install Bundle and check environment versions
run: |
echo 'Install Bundle'
bundle config path vendor/bundle
bundle install
echo 'Check environment setup versions'
ruby --version
gem --version
bundler --version
- name: Run Danger
uses: danger/[email protected]
env:
DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: bundle exec danger
27 changes: 27 additions & 0 deletions Dangerfile.df.kts
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import systems.danger.kotlin.*

danger(args) {
onGitHub {
// Make it more obvious that a PR is a work in progress and shouldn't be merged yet
if (pullRequest.title.contains("WIP")) {
warn("PR is classed as Work in Progress")
}

// Warn to encourage a PR description
if (pullRequest.body.isBlank()) {
warn("Please provide a summary in the PR description to make it easier to review")
}

// Warn to encourage that labels should have been used on the PR
if (pullRequest.labels.isEmpty()) {
warn("Please add labels to this PR")
}
}

onGit {
// Warn when there is a big PR
if (lineOfCode > 500) {
warn("Big PR")
}
}
}

0 comments on commit b971e0e

Please sign in to comment.