-
Notifications
You must be signed in to change notification settings - Fork 22
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[#494] Replace danger-ruby with danger-kotlin
- Loading branch information
1 parent
c6cc06d
commit b971e0e
Showing
2 changed files
with
28 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,30 +69,7 @@ jobs: | |
working-directory: ./template-compose | ||
run: ./gradlew koverMergedXmlReport | ||
|
||
- name: Set up Ruby | ||
uses: ruby/setup-ruby@v1 | ||
with: | ||
ruby-version: '2.7' | ||
|
||
- name: Cache gems | ||
uses: actions/cache@v2 | ||
with: | ||
path: vendor/bundle | ||
key: ${{ runner.os }}-gems-${{ hashFiles('**/Gemfile.lock') }} | ||
restore-keys: | | ||
${{ runner.os }}-gems- | ||
- name: Install Bundle and check environment versions | ||
run: | | ||
echo 'Install Bundle' | ||
bundle config path vendor/bundle | ||
bundle install | ||
echo 'Check environment setup versions' | ||
ruby --version | ||
gem --version | ||
bundler --version | ||
- name: Run Danger | ||
uses: danger/[email protected] | ||
env: | ||
DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
run: bundle exec danger |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import systems.danger.kotlin.* | ||
|
||
danger(args) { | ||
onGitHub { | ||
// Make it more obvious that a PR is a work in progress and shouldn't be merged yet | ||
if (pullRequest.title.contains("WIP")) { | ||
warn("PR is classed as Work in Progress") | ||
} | ||
|
||
// Warn to encourage a PR description | ||
if (pullRequest.body.isBlank()) { | ||
warn("Please provide a summary in the PR description to make it easier to review") | ||
} | ||
|
||
// Warn to encourage that labels should have been used on the PR | ||
if (pullRequest.labels.isEmpty()) { | ||
warn("Please add labels to this PR") | ||
} | ||
} | ||
|
||
onGit { | ||
// Warn when there is a big PR | ||
if (lineOfCode > 500) { | ||
warn("Big PR") | ||
} | ||
} | ||
} |