-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement initial mesh support #69
Conversation
TODO: I don't see any visual changes adjusting |
hi @christian-oreilly , I just ran this script as well on MacOS in VS Code, and it runs correctly: |
I had not. I had run Not sure if that can be useful to you. I'll be traveling for the next 3 weeks or so, so I may not be able to follow up on this before I return, but I wanted to share this before leaving. |
To clarify, the front-end source code is in TypeScript and requires transformation to load in the browser. The final assets are not checked into source control, so trying out new changes requires running a When publishing to PyPI, we build the files for others much like distributing wheels so others do not need to "compile" themselves. |
There were a bunch of API changes.... The typechecking makes it a lot easier to track down issues.
I'm going to merge to continue iteration. This PR also introduces better typesafety and code quality to the code base so I don't want to be blocked with that. @christian-oreilly when you are back ping me and we can find a time for you to try out the changes. |
Implements initial support for meshes. See
./examples/mesh_layers.ipynb
for an example. It is based on the corresponding JavaScript demo.