Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement initial mesh support #69

Merged
merged 8 commits into from
Jun 29, 2024
Merged

feat: Implement initial mesh support #69

merged 8 commits into from
Jun 29, 2024

Conversation

manzt
Copy link
Collaborator

@manzt manzt commented Jun 12, 2024

Implements initial support for meshes. See ./examples/mesh_layers.ipynb for an example. It is based on the corresponding JavaScript demo.

@manzt
Copy link
Collaborator Author

manzt commented Jun 12, 2024

TODO: I don't see any visual changes adjusting mesh[0].opacity = <new value> or mesh[0].visibile = False.

@christian-oreilly
Copy link
Collaborator

Great to see that this feature is moving forward! I fetched the branch and tried the mesh_layer.ipynb notebooks and it runs without issues but do not display any output

image

This behavior is on VS Code in MacOS.

@kolibril13
Copy link
Collaborator

hi @christian-oreilly , I just ran this script as well on MacOS in VS Code, and it runs correctly:
image
Did you run npm run dev before executing the notebook?

@christian-oreilly
Copy link
Collaborator

I had not. I had run npm run build. I did not know that npm run dev was necessary since I was not modifying the JS myself. In any case, I did now and it did not change anything. I also check with the normal Jupyter Notebook and JupyterLab and it also does not work there. I got a screenshot of the JS console when I run that cell:

image

Not sure if that can be useful to you. I'll be traveling for the next 3 weeks or so, so I may not be able to follow up on this before I return, but I wanted to share this before leaving.

@manzt
Copy link
Collaborator Author

manzt commented Jun 29, 2024

I had not. I had run npm run build. I did not know that npm run dev was necessary since I was not modifying the JS myself.

To clarify, the front-end source code is in TypeScript and requires transformation to load in the browser. The final assets are not checked into source control, so trying out new changes requires running a npm run build step.

When publishing to PyPI, we build the files for others much like distributing wheels so others do not need to "compile" themselves.

manzt added 4 commits June 28, 2024 23:25
There were a bunch of API changes....

The typechecking makes it a lot easier to track down issues.
@manzt
Copy link
Collaborator Author

manzt commented Jun 29, 2024

I'm going to merge to continue iteration. This PR also introduces better typesafety and code quality to the code base so I don't want to be blocked with that. @christian-oreilly when you are back ping me and we can find a time for you to try out the changes.

@manzt manzt merged commit dd9327a into main Jun 29, 2024
8 checks passed
@manzt manzt deleted the manzt/meshes branch June 29, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants