bump niimath version and enable some safari on tablet and desktop #6
+52
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps niimath to the latest version and enables Safari as an allowed browser if running on desktop or iPadOS.
I have tested this on macOS 15.2, iPadOS 18.2, and iOS 18.2. The iOS device is correctly not allowed to run the models, but desktop and iPads are. Tested on macOS laptop with M3 Max, and iPad Pro with M4 chip. Admittedly, these devices are all "pro-level" and I have not tested with lower end mobile devices from the Apple ecosystem.
I did try to run the models on my iPhone 15 pro max and even the lightweight three class segmentation model fails. So These devices should be disallowed.
Users are now alerted if their device is likely to not work. Previously, this was a silent check and we never actually told users that their device probably won't work.