Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename organization #904

Closed
wants to merge 2 commits into from
Closed

Rename organization #904

wants to merge 2 commits into from

Conversation

nightscape
Copy link
Owner

@nightscape nightscape commented Dec 4, 2024

PR Type

enhancement, documentation


Description

  • Renamed package from com.crealytics to dev.mauch across all source files.
  • Updated issue and repository references to point to the new GitHub repository (github.dev/mauch).
  • Added a new utility object ExcelSparkInternal for handling input file names.
  • Updated build configuration in build.mill to reflect the new organization and repository URL.
  • Upgraded Mill version to 0.12.3 in .mill-version.
  • Updated documentation files (CHANGELOG.md, README.md, issue templates) to reflect the new repository and package references.

Changes walkthrough 📝

Relevant files
Enhancement
3 files
KeepUndefinedRowsSuite.scala
Update package and issue references in KeepUndefinedRowsSuite

src/test/scala/dev/mauch/spark/excel/v2/KeepUndefinedRowsSuite.scala

  • Updated package name from com.crealytics to dev.mauch.
  • Updated issue references to new repository URL.
  • +4/-4     
    package.scala
    Update package and format strings in package.scala             

    src/main/scala/dev/mauch/spark/excel/package.scala

  • Updated package name from com.crealytics to dev.mauch.
  • Updated DataFrameReader and DataFrameWriter format strings.
  • +3/-3     
    ExcelSparkInternal.scala
    Add ExcelSparkInternal utility for input file handling     

    src/main/2.4/scala/dev/mauch/spark/ExcelSparkInternal.scala

  • Added a new utility object ExcelSparkInternal for handling input file
    names.
  • +25/-1   
    Documentation
    4 files
    CHANGELOG.md
    Update repository references in CHANGELOG.md                         

    CHANGELOG.md

  • Updated repository references from github.com/crealytics to
    github.dev/mauch.
  • +121/-121
    generic.yml
    Update package references in issue template                           

    .github/ISSUE_TEMPLATE/generic.yml

    • Updated package references in example commands and code snippets.
    +2/-2     
    ISSUE_TEMPLATE.md
    Update package references in ISSUE_TEMPLATE.md                     

    ISSUE_TEMPLATE.md

    • Updated package references in example commands and code snippets.
    +2/-2     
    README.md
    Update repository URL references in README.md                       

    src/README.md

    • Updated repository URL references to github.dev/mauch.
    +1/-1     
    Configuration changes
    2 files
    build.mill
    Update organization and repository URL in build.mill         

    build.mill

  • Updated organization from com.crealytics to dev.mauch.
  • Updated repository URL to github.dev/mauch.
  • +2/-2     
    org.apache.spark.sql.sources.DataSourceRegister
    Update DataSourceRegister entry for new package                   

    src/main/resources/META-INF/services/org.apache.spark.sql.sources.DataSourceRegister

    • Updated DataSourceRegister entry to reflect new package name.
    +1/-1     
    Dependencies
    1 files
    .mill-version
    Upgrade Mill version to 0.12.3                                                     

    .mill-version

    • Upgraded Mill version from 0.12.1 to 0.12.3.
    +1/-1     
    Additional files (token-limit)
    1 files
    README.md
    ...                                                                                                           

    README.md

    ...

    +17/-17 

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    github-actions bot commented Dec 4, 2024

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Namespace Error
    The package declaration uses 'org.apache.spark.crealytics' which seems incorrect. It should be aligned with the new organization namespace 'dev.mauch.spark'.

    Copy link

    github-actions bot commented Dec 4, 2024

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @nightscape nightscape force-pushed the rename-organization@origin branch from ff4f6bb to 57a3852 Compare December 4, 2024 15:24
    @nightscape nightscape closed this Dec 4, 2024
    @nightscape nightscape deleted the rename-organization@origin branch December 4, 2024 15:25
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant