Adding Tag Cloud Page. #161
Conversation
tags.html
Outdated
| <h1 class="tags-page-header"> | ||
| Tags | ||
| </h1> | ||
|
|
There was a problem hiding this comment.
Would it be possible to fix the indentations on this page please?
There was a problem hiding this comment.
done. There was a tabs/spaces mix up in the file. I converted them all to spaces.
_assets/stylesheets/_base.scss
Outdated
| @@ -153,3 +153,11 @@ img { | |||
| color: $white; | |||
| background-color: $gray-darkest; | |||
| } | |||
|
|
|||
| .text-center { | |||
There was a problem hiding this comment.
I would prefer to not use this and add the properties to the right classes in modules/tags.
There was a problem hiding this comment.
In my experience, I have encountered the need to use text-center a lot, so I have this clreated for almost all of my projects. And sure, let me know what styling you end up with. I was never good at that part anyway.
There was a problem hiding this comment.
@xRahul I know but for now please keep it in one file. I will introduce some functionality classes for this later!
There was a problem hiding this comment.
Should I inline it till then? or another scss file that gets imported in light/dark?
There was a problem hiding this comment.
@xRahul I would just add the properties to the classes created in tags.scss to be honest!
There was a problem hiding this comment.
that's fine too. I'll update the pr
|
@xRahul Nice! Once it's ready for merging I will merge it and style it a bit + add a link to the page. |
|
As the commits increased a lot, I'll raise another one. |
I have added the tag cloud from my website to the theme. I'm just not sure where we should put the link for this. Let me know if you have any thoughts. Also, I have not added the hash svg icon here, so if you have a source for them, we can use that too.
Issue: #128
Example: https://rahulja.in/tags