add e2e testing style guidelines #29
Conversation
marianna-exelate
requested review from
mystetskyivlad,
lidoravitan,
MatanBorenkraoutNielsen,
einatnielsen and
liadShiranNielsen
| - Common reusable logic that can be shared between tests (i.e login flow) | ||
| - Uses one or more Page Objects under the hood | ||
| - Has no assertions | ||
|
|
There was a problem hiding this comment.
I think it might be good to give an example of Flow
javascript/testing/README.md
Outdated
| }) | ||
| ``` | ||
|
|
||
| - **Page Object** |
There was a problem hiding this comment.
I think we can give a link for some article about Page Objects, for example, https://martinfowler.com/bliki/PageObject.html
javascript/testing/README.md
Outdated
| - **Test** | ||
| - Uses the [AAA pattern](#aaa-pattern---arrange-act-assert) | ||
| - One and only one unit that __has assertions__ for testing components' integration and data integrity | ||
| - Uses one or more `Page Objects` to access and interact with tested application page |
There was a problem hiding this comment.
Uses one or more Flows to implement "act" part of the test.
There was a problem hiding this comment.
Maybe we should start with PageObject, then Flow and only then with Test, which uses Page Object and Flow?
javascript/testing/README.md
Outdated
| - **Test** | ||
| - Uses the [AAA pattern](#aaa-pattern---arrange-act-assert) | ||
| - One and only one unit that __has assertions__ for testing components' integration and data integrity | ||
| - Uses one or more `Page Objects` to access and interact with tested application page |
There was a problem hiding this comment.
Maybe we should start with PageObject, then Flow and only then with Test, which uses Page Object and Flow?
javascript/testing/README.md
Outdated
| import TestPageObject from './TestPageObject' | ||
| const testPageObject = new TestPageObject() | ||
|
|
||
| it('should search data correctly', () => { |
There was a problem hiding this comment.
I think that in this test we are actually checking that searchTerm was displayed and not that data was searched correctly.
Or we need to change the assertion (which should check that there are corrected filtered elements) or change the title of the test (which I prefer more because don't want to make an example more complicated)
There was a problem hiding this comment.
I think that it checks filter by search term functionality, since the last assertion is getSearchResults().should('contain', 'searchTerm') - that checks search functionality
javascript/testing/README.md
Outdated
| ``` | ||
|
|
||
| - **Page Object** | ||
| - Responsible to encapsulate technical details (like css selectors, data attributes, etc`) to access the elements of the tested application page |
There was a problem hiding this comment.
"to access and manipulate", otherwise it seems that Page Object should be only getter specific
javascript/testing/README.md
Outdated
|
|
||
| - **Page Object** | ||
| - Responsible to encapsulate technical details (like css selectors, data attributes, etc`) to access the elements of the tested application page | ||
| - Provides an atomic API for interaction with tested application page. This API is used by `Test` |
There was a problem hiding this comment.
"Provides an API for atomic interactions with the tested application page" - I think that the operation should be atomic and not API
related to #11