Code

Enum-ify Theme.#89

Code

Merged

pserwylo merged 8 commits intonicolasbrailo:masternicolasbrailo/PianOli:masterfrom juleskers:theme-cleanupjuleskers/PianOli:theme-cleanupCopy head branch name to clipboardJan 28, 2024

+308-100

Commits

Commits on Jan 22, 2024

• Refactor Theme: docu + comments

  

  Jules Kerssemakers

  committed
  c319d70

• Refactor Theme: convert to enum.

  Show description for 03ab015
  

  Jules Kerssemakers

  committed
  03ab015

• Decouple Theme from android Context, to make it testable.

  Show description for ee1f04b
  

  Jules Kerssemakers

  committed
  ee1f04b

• Make Theme-from-Preference null-safe.

  Show description for 4bd3acd
  

  Jules Kerssemakers

  committed
  4bd3acd

• Oops: don't attempt to draw non-existing small keys.

  Show description for f319c16
  

  Jules Kerssemakers

  committed
  f319c16

• Move color decision for small keys into Theme.

  Show description for b42299b
  

  Jules Kerssemakers

  committed
  b42299b

• Move all area logic to Piano privates, to simplify drawing logic.

  Show description for 494aa49
  

  Jules Kerssemakers

  committed
  494aa49

• Theme javadoc, round 2.

  

  Jules Kerssemakers

  committed
  252fac1