acme_sh_renew_time_in_days does not work #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The acme.sh install task does not use the --days argument. The issue task does. Perhaps th renew task does as well. Slight change in wording to avoid a single apostrophe which was causing emacs to syntax highlight incorrectly.
bombaywalla
changed the title
|
Is this project still active? Looks promissing though. Would be nice if these fixes were merged. |
|
@DerDanilo I've had a year long project now where I've been adding and refactoring a bunch of Ansible roles. I have not been using this role for a long time, but I have a new role that uses acme-sh that acts more as a general PKI role (it supports ACME, self signed and 3rd party certs). It will be open sourced at some point when everything is ready. |
|
That sounds good. So I will go ahead and build my own role for our specific case until yours is ready. Can you estimate some time when you can release it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The renewal days value was used in the install (install of acme.sh itself) task. But acme.sh does not use the --days argument. However, the acme.sh issue task does use the --days argument. So, move the --days argument from the install task to the issue task.
The renew task also appears to use the --days argument. But, I was not able to verify that it would be appropriate to use the --days argument in the renew task as well.
Added |bool to avoid deprecation warnings where a bare var was used as a boolean.