Fix eternal loading progress #719 #697

app/src/main/java/io/plaidapp/ui/HomeActivity.kt

@@ -38,8 +38,10 @@ import android.view.View
 import android.view.ViewGroup
 import android.view.ViewStub
 import android.view.WindowInsets
+import android.widget.Button
 import android.widget.FrameLayout
 import android.widget.ImageView
+import android.widget.LinearLayout
 import android.widget.ProgressBar
 import android.widget.TextView
 import android.widget.Toast
@@ -118,9 +120,16 @@ class HomeActivity : AppCompatActivity() {
 
     private val noFiltersEmptyText by lazy {
         val view = findViewById<ViewStub>(R.id.stub_no_filters).inflate() as TextView
-        // create the no filters empty text
+        noFiltersEmptyText(R.string.no_filters_selected, view)
+    }
+
+    private val noDataView by lazy {
+        val view = findViewById<ViewStub>(R.id.stub_no_data).inflate() as LinearLayout
+        view.apply { findViewById<Button>(R.id.retryButton).setOnClickListener { viewModel.loadData() } }
+    }
 
-        val emptyText = getText(R.string.no_filters_selected) as SpannedString
+    private fun HomeActivity.noFiltersEmptyText(stringId: Int, view: TextView): TextView {
+        val emptyText = getText(stringId) as SpannedString
         val ssb = SpannableStringBuilder(emptyText)
         val annotations = emptyText.getSpans(0, emptyText.length, Annotation::class.java)
 
@@ -151,11 +160,9 @@ class HomeActivity : AppCompatActivity() {
             }
         }
 
-        with(view) {
+        return with(view) {
             text = ssb
-            setOnClickListener {
-                drawer.openDrawer(GravityCompat.END)
-            }
+            setOnClickListener { drawer.openDrawer(GravityCompat.END) }
             view
         }
     }
@@ -293,6 +300,10 @@ class HomeActivity : AppCompatActivity() {
                     val uiModel = viewModel.feedProgress.value
                     return uiModel?.isLoading ?: false
                 }
+
+                override fun onStopLoading() {
+                    checkEmptyState()
+                }
             }
 
         val shotPreloadSizeProvider = ViewPreloadSizeProvider<Shot>()
@@ -528,22 +539,25 @@ class HomeActivity : AppCompatActivity() {
             // if grid is empty check whether we're loading or if no filters are selected
             if (sourcesRepository.getActiveSourcesCount() > 0 && connectivityChecker != null) {
                 connectivityChecker?.connectedStatus?.value?.let {
-                    loading.visibility = View.VISIBLE
-                    setNoFiltersEmptyTextVisibility(View.GONE)
+                    if (filtersAdapter.getEnabledFilterCount() > 0) {
+                        setEmptyStateVisibility(View.GONE, View.VISIBLE, View.GONE)
+                    } else {
+                        setEmptyStateVisibility(View.VISIBLE, View.GONE, View.GONE)
+                    }
                 }
             } else {
-                loading.visibility = View.GONE
-                setNoFiltersEmptyTextVisibility(View.VISIBLE)
+                setEmptyStateVisibility(View.GONE, View.GONE, View.VISIBLE)
             }
             toolbar.translationZ = 0f
         } else {
-            loading.visibility = View.GONE
-            setNoFiltersEmptyTextVisibility(View.GONE)
+            setEmptyStateVisibility(View.GONE, View.GONE, View.GONE)
         }
     }
 
-    private fun setNoFiltersEmptyTextVisibility(visibility: Int) {
-        noFiltersEmptyText.visibility = visibility
+    private fun setEmptyStateVisibility(progressBar: Int, noData: Int, noFilter: Int) {
+        loading.visibility = progressBar
+        noDataView.visibility = noData
+        noFiltersEmptyText.visibility = noFilter
     }
 
     @Suppress("DEPRECATION")
@@ -641,7 +655,7 @@ class HomeActivity : AppCompatActivity() {
 
         TransitionManager.beginDelayedTransition(drawer)
         noConnection.visibility = View.GONE
-        loading.visibility = View.VISIBLE
+        checkEmptyState()
         viewModel.loadData()
     }
 

app/src/main/res/layout/activity_home.xml

@@ -61,6 +61,14 @@
             android:indeterminateTint="?android:colorAccent"
             android:indeterminateTintMode="src_in" />
 
+        <ViewStub
+            android:id="@+id/stub_no_data"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:layout_gravity="center"
+            android:layout_margin="@dimen/spacing_huge"
+            android:layout="@layout/no_data" />
+
         <ViewStub
             android:id="@+id/stub_no_filters"
             android:layout_width="wrap_content"

app/src/main/res/layout/no_data.xml

@@ -0,0 +1,30 @@
+<?xml version="1.0" encoding="utf-8"?>
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools"
+    android:id="@+id/noDataContainer"
+    android:layout_width="match_parent"
+    android:layout_height="wrap_content"
+    android:elevation="1dp"
+    android:orientation="vertical">
+
+    <TextView
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:gravity="center"
+        android:padding="@dimen/padding_normal"
+        android:text="@string/no_data"
+        android:textColor="@color/text_primary_light"
+        android:textSize="15sp"
+        tools:text="@string/no_data" />
+
+    <Button
+        android:id="@+id/retryButton"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_gravity="center"
+        android:foreground="?attr/selectableItemBackground"
+        android:text="@string/retry"
+        android:textAllCaps="false"
+        android:textSize="15sp" />
+
+</LinearLayout>

app/src/main/res/values/strings.xml

@@ -35,8 +35,10 @@
     <string name="add">Add</string>
     <string name="edit">Edit</string>
     <string name="no_filters_selected">No filters selected, press the filter button above (<annotation src="@drawable/ic_filter_small">&#2228;</annotation>)\n<i><annotation foregroundColor="@color/text_secondary_light">or swipe from the&#160;right</annotation></i></string>
+    <string name="no_data">Error loading data</string>
 
     <!--searchable label-->
     <string name="search_hint">Search Dribbble &amp; Designer News</string>
+    <string name="retry">Retry</string>
 
 </resources>

core/src/main/java/io/plaidapp/core/ui/filter/FilterAdapter.kt

@@ -65,8 +65,8 @@ class FilterAdapter : ListAdapter<SourceUiModel, FilterViewHolder>(sourceUiModel
 
     override fun onCreateViewHolder(viewGroup: ViewGroup, viewType: Int): FilterViewHolder {
         val holder = FilterViewHolder(
-                LayoutInflater.from(viewGroup.context)
-                        .inflate(R.layout.filter_item, viewGroup, false)
+            LayoutInflater.from(viewGroup.context)
+                .inflate(R.layout.filter_item, viewGroup, false)
         )
         holder.itemView.setOnClickListener {
             val position = holder.adapterPosition
@@ -109,4 +109,12 @@ class FilterAdapter : ListAdapter<SourceUiModel, FilterViewHolder>(sourceUiModel
         val uiModel = getItem(position)
         uiModel.onSourceDismissed(uiModel)
     }
+
+    fun getEnabledFilterCount(): Int {
+        var count = 0
+        currentList.map {
+            if (it.active) count = count.inc()
+        }
+        return count
+    }
 }

core/src/main/java/io/plaidapp/core/ui/recyclerview/InfiniteScrollListener.kt

@@ -37,13 +37,17 @@ abstract class InfiniteScrollListener(
         val totalItemCount = layoutManager.itemCount
         val firstVisibleItem = layoutManager.findFirstVisibleItemPosition()
 
-        if (totalItemCount - visibleItemCount <= firstVisibleItem + VISIBLE_THRESHOLD) {
+        if (totalItemCount - visibleItemCount <= firstVisibleItem + VISIBLE_THRESHOLD && totalItemCount > 0) {
             recyclerView.post(loadMoreRunnable)
+        } else {
+            onStopLoading()
         }
     }
 
     abstract fun onLoadMore()
 
+    abstract fun onStopLoading()
+
     abstract fun isDataLoading(): Boolean
 
     companion object {

search/src/main/java/io/plaidapp/search/domain/LoadSearchDataUseCase.kt

@@ -57,6 +57,7 @@ class LoadSearchDataUseCase(
                 deferredJobs.add(async { it.loadMore() })
             }
         }
+        if (_searchResult.value == null) _searchResult.postValue(emptyList())
         deferredJobs.awaitAll()
     }
 

search/src/main/java/io/plaidapp/search/ui/SearchActivity.kt

@@ -169,6 +169,8 @@ class SearchActivity : AppCompatActivity() {
                 override fun isDataLoading(): Boolean {
                     return viewModel.searchProgress.value?.isLoading ?: false
                 }
+
+                override fun onStopLoading() {}
             })
             setHasFixedSize(true)