Feature: Support loading manifests from remote locations #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or until this project no longer matters
luiherch
suggested changes
Oct 7, 2024
luiherch
approved these changes
Oct 9, 2024
nicholasyager
deleted the
86-support-loading-manifests-from-remote-locations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
This PR supports issue #86, enabling the use of generic URLs in addition to file paths for referencing manifest file locations. This opens the door to allowing for more flexible hosting arrangements that are not constrained by S3 or other specific service providers.
To accomplish this, I modified the
FileReferenceConfigtype to have aurllibParsedResulttype, added a pre-validation step to convert strings to this type, and then split outload_from_local_filesystemto useload_from_path, which checks the URL scheme to decide on which scheme-specific loader to use. For now, this is onlyfile-based schemes orhttp(s)schemes. In the future, the options may grow.To-do