Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test for today's date in doctest #200

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

jspricke
Copy link

@jspricke jspricke commented Nov 3, 2024

The return value depends on the actual date thus making the test flaky.

The return value depends on the actual date thus making the test flaky.
@niccokunzmann
Copy link
Owner

Hi, thanks. I have to think about it. I'd rather monkeypatch than remove documentation.

@niccokunzmann niccokunzmann merged commit afdfdfb into niccokunzmann:main Nov 3, 2024
8 checks passed
@jspricke jspricke deleted the fix_doctest branch November 3, 2024 10:06
@jspricke
Copy link
Author

jspricke commented Nov 3, 2024

monkeypatch would be fine but I don't think it makes up for a better documentation in the README.md. On the other hand it looks like there are enough examples already.

@niccokunzmann
Copy link
Owner

cool! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants