Validate input references (CDs, sections, channels) #107

mdcerna · 2019-10-07T16:38:49Z

This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Fixes #45
All section IDs are now being validated. If not the correct section name, we return a useful error message with the expected section name.

The expected SLSC Switch and Routing and Faulting custom device ID is also validated. The RaF custom device Name is validated and the expected name is returned in the error message. For SLSC Switch, the Name can change so instead we check using the expected GUID.

Fixes #29
Simple cleanup to remove unnecessary .NET object instantiation (and Close).

Why should this Pull Request be merged?

This will reduce the headache of misusing section and custom device IDs, easily done with LV mis-wiring.

What testing has been done?

Added an automated test. Re-ran all existing tests.

…alidation. Finished out the test for section validation.

…(by GUID, as Name is not constant)

niveristand-diff-bot · 2019-10-07T17:45:54Z

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Routing and Faulting Scripting Unit Tests.lvclass--test Check for Invalid Section IDs.vi.png

Routing and Faulting Scripting.lvlib--Add Alias.vi.png

Routing and Faulting Scripting.lvlib--Add Routing Channel.vi.png

Routing and Faulting Scripting.lvlib--Find Endpoint Aliases and Routing Channels Sections.vi.png

Routing and Faulting Scripting.lvlib--Find Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Get Alias Mappings.vi.png

Routing and Faulting Scripting.lvlib--Get Alias.vi.png

Routing and Faulting Scripting.lvlib--Get All Routing Channel Ref IDs.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel by Name.vi.png

Routing and Faulting Scripting.lvlib--Initialize Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Remove Alias.vi.png

Routing and Faulting Scripting.lvlib--Remove All Aliases.vi.png

Routing and Faulting Scripting.lvlib--Remove Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Remove Routing Channel.vi.png

Routing and Faulting Scripting.lvlib--Set Alias Endpoint.vi.png

Routing and Faulting Scripting.lvlib--Validate Routing Channel Parameters.vi.png

Routing and Faulting Scripting.lvlib--Validate Section ID.vi.png

SLSC Switch Scripting.lvlib--Find Endpoint Configuration Section.vi.png

SLSC Switch Scripting.lvlib--Get All Endpoint Configurations.vi.png

SLSC Switch Scripting.lvlib--Get Endpoint Configuration.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Capabilities.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Description.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Model.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Resource.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Topology.vi.png

SLSC Switch Scripting.lvlib--Set Endpoint Configuration.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Capabilities.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Description.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Model.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Resource.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Topology.vi.png

SLSC Switch Scripting.lvlib--Validate ID by GUID.vi.png

SLSC Switch Scripting.lvlib--Validate Section ID.vi.png

niveristand-diff-bot · 2019-10-07T21:00:50Z

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Routing and Faulting Scripting Unit Tests.lvclass--test Check for Invalid Section IDs.vi.png

Routing and Faulting Scripting.lvlib--Add Alias.vi.png

Routing and Faulting Scripting.lvlib--Add Routing Channel.vi.png

Routing and Faulting Scripting.lvlib--Find Endpoint Aliases and Routing Channels Sections.vi.png

Routing and Faulting Scripting.lvlib--Find Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Get Alias Mappings.vi.png

Routing and Faulting Scripting.lvlib--Get Alias.vi.png

Routing and Faulting Scripting.lvlib--Get All Routing Channel Ref IDs.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel by Name.vi.png

Routing and Faulting Scripting.lvlib--Initialize Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Remove Alias.vi.png

Routing and Faulting Scripting.lvlib--Remove All Aliases.vi.png

Routing and Faulting Scripting.lvlib--Remove Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Remove Routing Channel.vi.png

Routing and Faulting Scripting.lvlib--Set Alias Endpoint.vi.png

Routing and Faulting Scripting.lvlib--Validate Routing Channel Parameters.vi.png

Routing and Faulting Scripting.lvlib--Validate Section ID.vi.png

SLSC Switch Scripting.lvlib--Find Endpoint Configuration Section.vi.png

SLSC Switch Scripting.lvlib--Get All Endpoint Configurations.vi.png

SLSC Switch Scripting.lvlib--Get Endpoint Configuration.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Capabilities.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Description.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Model.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Resource.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Topology.vi.png

SLSC Switch Scripting.lvlib--Set Endpoint Configuration.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Capabilities.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Description.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Model.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Resource.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Topology.vi.png

SLSC Switch Scripting.lvlib--Validate ID by GUID.vi.png

SLSC Switch Scripting.lvlib--Validate Section ID.vi.png

csjall · 2019-10-08T14:17:58Z

Validate Section ID.vi

Rename to Validate Custom Device Section Name. This VI is validating the section name for a custom device, not the section ID. Ensure that your VI names reflect what they are actually doing.
Consider putting a case around the VI to skip all code in the case of incoming error. This is important as currently you are eating any incoming errors.
Create a subVI to validate Routing and Faulting Custom Device reference.

Add N Aliases.vi

Be consistent with section name validation. You are not validating the section name, instead relying on Add Alias.vi to validate the section name. However in Remove All Aliases.vi you are validating the section name in both the top level VI and the lower level Remove Alias.vi.

Endpoint Aliases

Create a subVI to validate the Endpoint Aliases reference.

Get Routing Channel Configuration.vi

Validate section Ref. Currently you are relying on VeriStand to validate the channel references. Consider creating a subVI that validates channel ref by checking the GUID.

Routing Channels

Create a subVI to validate Routing Channel reference.

niveristand-diff-bot · 2019-10-08T15:13:36Z

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Routing and Faulting Scripting Unit Tests.lvclass--test Check for Invalid Section IDs.vi.png

Routing and Faulting Scripting.lvlib--Add Alias.vi.png

Routing and Faulting Scripting.lvlib--Add Routing Channel.vi.png

Routing and Faulting Scripting.lvlib--Find Endpoint Aliases and Routing Channels Sections.vi.png

Routing and Faulting Scripting.lvlib--Find Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Get Alias Mappings.vi.png

Routing and Faulting Scripting.lvlib--Get Alias.vi.png

Routing and Faulting Scripting.lvlib--Get All Routing Channel Ref IDs.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel by Name.vi.png

Routing and Faulting Scripting.lvlib--Initialize Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Remove Alias.vi.png

Routing and Faulting Scripting.lvlib--Remove All Aliases.vi.png

Routing and Faulting Scripting.lvlib--Remove Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Remove Routing Channel.vi.png

Routing and Faulting Scripting.lvlib--Set Alias Endpoint.vi.png

Routing and Faulting Scripting.lvlib--Validate Routing Channel Parameters.vi.png

Routing and Faulting Scripting.lvlib--Validate Section ID.vi.png

SLSC Switch Scripting.lvlib--Find Endpoint Configuration Section.vi.png

SLSC Switch Scripting.lvlib--Get All Endpoint Configurations.vi.png

SLSC Switch Scripting.lvlib--Get Endpoint Configuration.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Capabilities.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Description.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Model.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Resource.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Topology.vi.png

SLSC Switch Scripting.lvlib--Set Endpoint Configuration.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Capabilities.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Description.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Model.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Resource.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Topology.vi.png

SLSC Switch Scripting.lvlib--Validate ID by GUID.vi.png

SLSC Switch Scripting.lvlib--Validate Section ID.vi.png

Added 2-in 2-out Validate functions to simplify call sites Changed all reference ID checks to use generic BaseNode .Net calls (Name and GUID properties) Added case structure for validate functions

validate CD reference, Endpoint Conifiguation reference updated tests

niveristand-diff-bot · 2019-10-08T19:08:27Z

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Routing and Faulting Scripting.lvlib--Add Alias.vi.png

Routing and Faulting Scripting.lvlib--Add Routing Channel.vi.png

Routing and Faulting Scripting.lvlib--Find Endpoint Aliases and Routing Channels Sections.vi.png

Routing and Faulting Scripting.lvlib--Find Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Get Alias Mappings.vi.png

Routing and Faulting Scripting.lvlib--Get Alias.vi.png

Routing and Faulting Scripting.lvlib--Get All Routing Channel Ref IDs.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel by Name.vi.png

Routing and Faulting Scripting.lvlib--Initialize Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Remove Alias.vi.png

Routing and Faulting Scripting.lvlib--Remove All Aliases.vi.png

Routing and Faulting Scripting.lvlib--Remove Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Remove Routing Channel.vi.png

Routing and Faulting Scripting.lvlib--Set Alias Endpoint.vi.png

Routing and Faulting Scripting.lvlib--Validate Routing Channel Parameters.vi.png

Routing and Faulting Scripting.lvlib--Validate Section ID.vi.png

SLSC Switch Scripting.lvlib--Find Endpoint Configuration Section.vi.png

SLSC Switch Scripting.lvlib--Get All Endpoint Configurations.vi.png

SLSC Switch Scripting.lvlib--Get Endpoint Configuration.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Capabilities.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Description.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Model.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Resource.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Topology.vi.png

SLSC Switch Scripting.lvlib--Set Endpoint Configuration.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Capabilities.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Description.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Model.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Resource.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Topology.vi.png

SLSC Switch Scripting.lvlib--Validate ID by GUID.vi.png

SLSC Switch Scripting.lvlib--Validate Section ID.vi.png

The following VIs could not be diffed:

C:\jenkins\workspace\nd-faulting-custom-device_PR-107\Source\Routing and Faulting\Scripting\Tests\Unit\test Check for Invalid Section IDs.vi

niveristand-diff-bot · 2019-10-08T19:51:48Z

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Routing and Faulting Scripting.lvlib--Add Alias.vi.png

Routing and Faulting Scripting.lvlib--Add N Aliases.vi.png

Routing and Faulting Scripting.lvlib--Add Routing Channel.vi.png

Routing and Faulting Scripting.lvlib--Find Endpoint Aliases and Routing Channels Sections.vi.png

Routing and Faulting Scripting.lvlib--Find Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Get Alias Mappings.vi.png

Routing and Faulting Scripting.lvlib--Get Alias.vi.png

Routing and Faulting Scripting.lvlib--Get All Routing Channel Ref IDs.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel by Name.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel Configuration.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel Initial State.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel State Configurations.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel State-Value Table.vi.png

Routing and Faulting Scripting.lvlib--Initialize Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Remove Alias.vi.png

Routing and Faulting Scripting.lvlib--Remove All Aliases.vi.png

Routing and Faulting Scripting.lvlib--Remove Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Remove Routing Channel.vi.png

Routing and Faulting Scripting.lvlib--Set Alias Endpoint.vi.png

Routing and Faulting Scripting.lvlib--Set Routing Channel Description.vi.png

Routing and Faulting Scripting.lvlib--Set Routing Channel Initial State.vi.png

Routing and Faulting Scripting.lvlib--Set Routing Channel Name.vi.png

Routing and Faulting Scripting.lvlib--Set Routing Channel State Configurations.vi.png

Routing and Faulting Scripting.lvlib--Validate Endpoint Aliases Reference.vi.png

Routing and Faulting Scripting.lvlib--Validate Reference by GUID.vi.png

Routing and Faulting Scripting.lvlib--Validate Reference by Name.vi.png

Routing and Faulting Scripting.lvlib--Validate Routing Channel Parameters.vi.png

Routing and Faulting Scripting.lvlib--Validate Routing Channel Reference.vi.png

Routing and Faulting Scripting.lvlib--Validate Routing Channels Reference.vi.png

SLSC Switch Scripting.lvlib--Find Endpoint Configuration Section.vi.png

SLSC Switch Scripting.lvlib--Get All Endpoint Configurations.vi.png

SLSC Switch Scripting.lvlib--Get Endpoint Configuration.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Capabilities.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Description.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Model.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Resource.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Topology.vi.png

SLSC Switch Scripting.lvlib--Initialize SLSC Switch Custom Device.vi.png

SLSC Switch Scripting.lvlib--Remove SLSC Switch Custom Device.vi.png

SLSC Switch Scripting.lvlib--Set All Endpoint Configurations.vi.png

SLSC Switch Scripting.lvlib--Set Endpoint Configuration.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Capabilities.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Description.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Model.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Resource.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Topology.vi.png

SLSC Switch Scripting.lvlib--Validate Endpoint Configuration Reference.vi.png

SLSC Switch Scripting.lvlib--Validate Reference by GUID.vi.png

SLSC Switch Scripting.lvlib--Validate Reference by Name.vi.png

SLSC Switch Scripting.lvlib--Validate SLSC CD Reference.vi.png

The following VIs could not be diffed:

C:\jenkins\workspace\nd-faulting-custom-device_PR-107\Source\Routing and Faulting\Scripting\Tests\Unit\test Check for Invalid Section IDs.vi
C:\jenkins\workspace\nd-faulting-custom-device_PR-107\Source\SLSC Switch\Scripting\Tests\Unit\test Endpoint Configurations.vi
C:\jenkins\workspace\nd-faulting-custom-device_PR-107\Source\SLSC Switch\Scripting\Tests\Unit\test Find and Initialize SLSC Switch CD.vi

niveristand-diff-bot · 2019-10-08T23:44:26Z

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Routing and Faulting Scripting Unit Tests.lvclass--test Check for Invalid Section IDs.vi.png

Routing and Faulting Scripting.lvlib--Add Alias.vi.png

Routing and Faulting Scripting.lvlib--Add Connection to State.vi.png

Routing and Faulting Scripting.lvlib--Add N Aliases.vi.png

Routing and Faulting Scripting.lvlib--Add Routing Channel.vi.png

Routing and Faulting Scripting.lvlib--Add State to Routing Channel.vi.png

Routing and Faulting Scripting.lvlib--Add Status Channels.vi.png

Routing and Faulting Scripting.lvlib--Find Endpoint Aliases and Routing Channels Sections.vi.png

Routing and Faulting Scripting.lvlib--Find Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Get Alias Mappings.vi.png

Routing and Faulting Scripting.lvlib--Get Alias.vi.png

Routing and Faulting Scripting.lvlib--Get All Routing Channel Ref IDs.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel by Name.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel Configuration.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel Initial State.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel State Configurations.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel State-Value Table.vi.png

Routing and Faulting Scripting.lvlib--Get State from Routing Channel.vi.png

Routing and Faulting Scripting.lvlib--Initialize Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Remove Alias.vi.png

Routing and Faulting Scripting.lvlib--Remove All Aliases.vi.png

Routing and Faulting Scripting.lvlib--Remove Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Remove Routing Channel State.vi.png

Routing and Faulting Scripting.lvlib--Remove Routing Channel.vi.png

Routing and Faulting Scripting.lvlib--Remove State Connection.vi.png

Routing and Faulting Scripting.lvlib--Rename State.vi.png

Routing and Faulting Scripting.lvlib--Set Alias Endpoint.vi.png

Routing and Faulting Scripting.lvlib--Set Routing Channel Description.vi.png

Routing and Faulting Scripting.lvlib--Set Routing Channel Initial State.vi.png

Routing and Faulting Scripting.lvlib--Set Routing Channel Name.vi.png

Routing and Faulting Scripting.lvlib--Set Routing Channel State Configurations.vi.png

Routing and Faulting Scripting.lvlib--Set State Connections.vi.png

Routing and Faulting Scripting.lvlib--Set State Description.vi.png

Routing and Faulting Scripting.lvlib--Set State Value.vi.png

Routing and Faulting Scripting.lvlib--Validate Endpoint Aliases Reference.vi.png

Routing and Faulting Scripting.lvlib--Validate RaF Custom Device Reference.vi.png

Routing and Faulting Scripting.lvlib--Validate Reference by GUID.vi.png

Routing and Faulting Scripting.lvlib--Validate Reference by Name.vi.png

Routing and Faulting Scripting.lvlib--Validate Routing Channel Parameters.vi.png

Routing and Faulting Scripting.lvlib--Validate Routing Channel Reference.vi.png

Routing and Faulting Scripting.lvlib--Validate Routing Channels Reference.vi.png

SLSC Switch Scripting Unit Tests.lvclass--test Endpoint Configurations.vi.png

SLSC Switch Scripting Unit Tests.lvclass--test Find and Initialize SLSC Switch CD.vi.png

SLSC Switch Scripting.lvlib--Find Endpoint Configuration Section.vi.png

SLSC Switch Scripting.lvlib--Get All Endpoint Configurations.vi.png

SLSC Switch Scripting.lvlib--Get Endpoint Configuration.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Capabilities.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Description.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Model.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Resource.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Topology.vi.png

SLSC Switch Scripting.lvlib--Initialize SLSC Switch Custom Device.vi.png

SLSC Switch Scripting.lvlib--Remove SLSC Switch Custom Device.vi.png

SLSC Switch Scripting.lvlib--Set All Endpoint Configurations.vi.png

SLSC Switch Scripting.lvlib--Set Endpoint Configuration.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Capabilities.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Description.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Model.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Resource.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Topology.vi.png

SLSC Switch Scripting.lvlib--Validate Endpoint Configuration Reference.vi.png

SLSC Switch Scripting.lvlib--Validate Reference by GUID.vi.png

SLSC Switch Scripting.lvlib--Validate Reference by Name.vi.png

SLSC Switch Scripting.lvlib--Validate SLSC CD Reference.vi.png

csjall · 2019-10-09T14:27:49Z

Get All Endpoint Configurations.vi: Replace Validate Reference by Name.vi with Validate Endpoint Configuration Reference.vi.
Validate Reference By Name/Guid.vi: Change terminal pattern to use the left edge. By convention we want to fill up the left edge before wiring top or bottom edges.
D.R.Y. We have identical VIs (Validate Reference by GUID.vi and Validate Reference by Name.vi) checked into both SLSC Switch, and Routing and Faulting scripting. Create a tech debt issue to single source this code (and other common code) for the scripting libraries.

Use Validate Endpoint Configuration Reference in Get All Endpoint Configurations.vi

mdcerna · 2019-10-09T15:07:10Z

D.R.Y. We have identical VIs (Validate Reference by GUID.vi and Validate Reference by Name.vi) checked into both SLSC Switch, and Routing and Faulting scripting. Create a tech debt issue to single source this code (and other common code) for the scripting libraries.

Scrub scripting libraries for duplicated code #109

niveristand-diff-bot · 2019-10-09T16:06:28Z

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Routing and Faulting Scripting Unit Tests.lvclass--test Check for Invalid Section IDs.vi.png

Routing and Faulting Scripting.lvlib--Add Alias.vi.png

Routing and Faulting Scripting.lvlib--Add Connection to State.vi.png

Routing and Faulting Scripting.lvlib--Add N Aliases.vi.png

Routing and Faulting Scripting.lvlib--Add Routing Channel.vi.png

Routing and Faulting Scripting.lvlib--Add State to Routing Channel.vi.png

Routing and Faulting Scripting.lvlib--Add Status Channels.vi.png

Routing and Faulting Scripting.lvlib--Find Endpoint Aliases and Routing Channels Sections.vi.png

Routing and Faulting Scripting.lvlib--Find Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Get Alias Mappings.vi.png

Routing and Faulting Scripting.lvlib--Get Alias.vi.png

Routing and Faulting Scripting.lvlib--Get All Routing Channel Ref IDs.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel by Name.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel Configuration.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel Initial State.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel State Configurations.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel State-Value Table.vi.png

Routing and Faulting Scripting.lvlib--Get State from Routing Channel.vi.png

Routing and Faulting Scripting.lvlib--Initialize Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Remove Alias.vi.png

Routing and Faulting Scripting.lvlib--Remove All Aliases.vi.png

Routing and Faulting Scripting.lvlib--Remove Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Remove Routing Channel State.vi.png

Routing and Faulting Scripting.lvlib--Remove Routing Channel.vi.png

Routing and Faulting Scripting.lvlib--Remove State Connection.vi.png

Routing and Faulting Scripting.lvlib--Rename State.vi.png

Routing and Faulting Scripting.lvlib--Set Alias Endpoint.vi.png

Routing and Faulting Scripting.lvlib--Set Routing Channel Description.vi.png

Routing and Faulting Scripting.lvlib--Set Routing Channel Initial State.vi.png

Routing and Faulting Scripting.lvlib--Set Routing Channel Name.vi.png

Routing and Faulting Scripting.lvlib--Set Routing Channel State Configurations.vi.png

Routing and Faulting Scripting.lvlib--Set State Connections.vi.png

Routing and Faulting Scripting.lvlib--Set State Description.vi.png

Routing and Faulting Scripting.lvlib--Set State Value.vi.png

Routing and Faulting Scripting.lvlib--Validate Endpoint Aliases Reference.vi.png

Routing and Faulting Scripting.lvlib--Validate RaF Custom Device Reference.vi.png

Routing and Faulting Scripting.lvlib--Validate Reference by GUID.vi.png

Routing and Faulting Scripting.lvlib--Validate Reference by Name.vi.png

Routing and Faulting Scripting.lvlib--Validate Routing Channel Parameters.vi.png

Routing and Faulting Scripting.lvlib--Validate Routing Channel Reference.vi.png

Routing and Faulting Scripting.lvlib--Validate Routing Channels Reference.vi.png

SLSC Switch Scripting Unit Tests.lvclass--test Endpoint Configurations.vi.png

SLSC Switch Scripting Unit Tests.lvclass--test Find and Initialize SLSC Switch CD.vi.png

SLSC Switch Scripting.lvlib--Find Endpoint Configuration Section.vi.png

SLSC Switch Scripting.lvlib--Get All Endpoint Configurations.vi.png

SLSC Switch Scripting.lvlib--Get Endpoint Configuration.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Capabilities.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Description.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Model.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Resource.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Topology.vi.png

SLSC Switch Scripting.lvlib--Initialize SLSC Switch Custom Device.vi.png

SLSC Switch Scripting.lvlib--Remove SLSC Switch Custom Device.vi.png

SLSC Switch Scripting.lvlib--Set All Endpoint Configurations.vi.png

SLSC Switch Scripting.lvlib--Set Endpoint Configuration.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Capabilities.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Description.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Model.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Resource.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Topology.vi.png

SLSC Switch Scripting.lvlib--Validate Endpoint Configuration Reference.vi.png

SLSC Switch Scripting.lvlib--Validate Reference by GUID.vi.png

SLSC Switch Scripting.lvlib--Validate Reference by Name.vi.png

SLSC Switch Scripting.lvlib--Validate SLSC CD Reference.vi.png

niveristand-diff-bot · 2019-10-09T16:55:00Z

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Routing and Faulting Scripting Unit Tests.lvclass--test Check for Invalid Section IDs.vi.png

Routing and Faulting Scripting.lvlib--Add Alias.vi.png

Routing and Faulting Scripting.lvlib--Add Connection to State.vi.png

Routing and Faulting Scripting.lvlib--Add N Aliases.vi.png

Routing and Faulting Scripting.lvlib--Add Routing Channel.vi.png

Routing and Faulting Scripting.lvlib--Add State to Routing Channel.vi.png

Routing and Faulting Scripting.lvlib--Add Status Channels.vi.png

Routing and Faulting Scripting.lvlib--Find Endpoint Aliases and Routing Channels Sections.vi.png

Routing and Faulting Scripting.lvlib--Find Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Get Alias Mappings.vi.png

Routing and Faulting Scripting.lvlib--Get Alias.vi.png

Routing and Faulting Scripting.lvlib--Get All Routing Channel Ref IDs.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel by Name.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel Configuration.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel Initial State.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel State Configurations.vi.png

Routing and Faulting Scripting.lvlib--Get Routing Channel State-Value Table.vi.png

Routing and Faulting Scripting.lvlib--Get State from Routing Channel.vi.png

Routing and Faulting Scripting.lvlib--Initialize Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Remove Alias.vi.png

Routing and Faulting Scripting.lvlib--Remove All Aliases.vi.png

Routing and Faulting Scripting.lvlib--Remove Routing and Faulting Custom Device.vi.png

Routing and Faulting Scripting.lvlib--Remove Routing Channel State.vi.png

Routing and Faulting Scripting.lvlib--Remove Routing Channel.vi.png

Routing and Faulting Scripting.lvlib--Remove State Connection.vi.png

Routing and Faulting Scripting.lvlib--Rename State.vi.png

Routing and Faulting Scripting.lvlib--Set Alias Endpoint.vi.png

Routing and Faulting Scripting.lvlib--Set Routing Channel Description.vi.png

Routing and Faulting Scripting.lvlib--Set Routing Channel Initial State.vi.png

Routing and Faulting Scripting.lvlib--Set Routing Channel Name.vi.png

Routing and Faulting Scripting.lvlib--Set Routing Channel State Configurations.vi.png

Routing and Faulting Scripting.lvlib--Set State Connections.vi.png

Routing and Faulting Scripting.lvlib--Set State Description.vi.png

Routing and Faulting Scripting.lvlib--Set State Value.vi.png

Routing and Faulting Scripting.lvlib--Validate Endpoint Aliases Reference.vi.png

Routing and Faulting Scripting.lvlib--Validate RaF Custom Device Reference.vi.png

Routing and Faulting Scripting.lvlib--Validate Reference by GUID.vi.png

Routing and Faulting Scripting.lvlib--Validate Reference by Name.vi.png

Routing and Faulting Scripting.lvlib--Validate Routing Channel Parameters.vi.png

Routing and Faulting Scripting.lvlib--Validate Routing Channel Reference.vi.png

Routing and Faulting Scripting.lvlib--Validate Routing Channels Reference.vi.png

SLSC Switch Scripting Unit Tests.lvclass--test Endpoint Configurations.vi.png

SLSC Switch Scripting Unit Tests.lvclass--test Find and Initialize SLSC Switch CD.vi.png

SLSC Switch Scripting.lvlib--Find Endpoint Configuration Section.vi.png

SLSC Switch Scripting.lvlib--Get All Endpoint Configurations.vi.png

SLSC Switch Scripting.lvlib--Get Endpoint Configuration.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Capabilities.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Description.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Model.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Resource.vi.png

SLSC Switch Scripting.lvlib--Get SLSC Switch Topology.vi.png

SLSC Switch Scripting.lvlib--Initialize SLSC Switch Custom Device.vi.png

SLSC Switch Scripting.lvlib--Remove SLSC Switch Custom Device.vi.png

SLSC Switch Scripting.lvlib--Set All Endpoint Configurations.vi.png

SLSC Switch Scripting.lvlib--Set Endpoint Configuration.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Capabilities.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Description.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Model.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Resource.vi.png

SLSC Switch Scripting.lvlib--Set SLSC Switch Topology.vi.png

SLSC Switch Scripting.lvlib--Validate Endpoint Configuration Reference.vi.png

SLSC Switch Scripting.lvlib--Validate Reference by GUID.vi.png

SLSC Switch Scripting.lvlib--Validate Reference by Name.vi.png

SLSC Switch Scripting.lvlib--Validate SLSC CD Reference.vi.png

Mike Cerna added 15 commits October 2, 2019 11:25

initial test

88955eb

Add validation of the section IDs - using Name property of the node ID

43adde1

2nd save

671e74d

Merge branch 'master' into dev/validate_input_params

62a4032

revert Add Alias

2c9712c

revert to master

0444d29

Added section validation.

80f1ee1

Merge branch 'master' into dev/validate_input_params

debf644

add section-checking

512fbab

Added checks for RaF custom device ID

7d17293

Merge branch 'master' into dev/validate_input_params

6d3c155

Added check for Routing Channel Ref ID to complete the Add RaF Chan v…

433879d

…alidation. Finished out the test for section validation.

Added checks - Endpoint section check (by Name), Custom Device check …

c9284a3

…(by GUID, as Name is not constant)

remove unnecessary object instantiation

f94d1bc

diagram cleanup

a6a0de4

mdcerna requested review from buckd and csjall as code owners October 7, 2019 16:38

mdcerna changed the title ~~Validate input section and CD ref IDs~~ Validate input references (CDs, sections, channels) Oct 8, 2019

Mike Cerna added 5 commits October 8, 2019 13:22

Added Routing Channel reference validation

89cae70

Added 2-in 2-out Validate functions to simplify call sites Changed all reference ID checks to use generic BaseNode .Net calls (Name and GUID properties) Added case structure for validate functions

updated test

411641d

add to previous commit

420ba81

apply same validation changes to SLSC Switch

e08e38a

validate CD reference, Endpoint Conifiguation reference updated tests

Merge branch 'master' into dev/validate_input_params

59469dd

csjall mentioned this pull request Oct 8, 2019

Add support for auto-detecting switching hardware, exporting possible connections #103

Merged

1 task

Mike Cerna added 3 commits October 8, 2019 16:42

Added channel reference validation to State/Connection functions.

c5d9549

Added RaF CD reference validation function

a480bb6

Merge branch 'master' into dev/validate_input_params

6f095cb

Connections come from the left instead of from below.

76a81f0

Use Validate Endpoint Configuration Reference in Get All Endpoint Configurations.vi

csjall approved these changes Oct 9, 2019

View reviewed changes

mdcerna merged commit 4456971 into master Oct 9, 2019

mdcerna deleted the dev/validate_input_params branch October 9, 2019 16:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validate input references (CDs, sections, channels) #107

Validate input references (CDs, sections, channels) #107

mdcerna commented Oct 7, 2019

niveristand-diff-bot commented Oct 7, 2019

niveristand-diff-bot commented Oct 7, 2019

csjall commented Oct 8, 2019 •

edited by mdcerna

Loading

niveristand-diff-bot commented Oct 8, 2019

niveristand-diff-bot commented Oct 8, 2019

niveristand-diff-bot commented Oct 8, 2019

niveristand-diff-bot commented Oct 8, 2019

csjall commented Oct 9, 2019 •

edited by mdcerna

Loading

mdcerna commented Oct 9, 2019

niveristand-diff-bot commented Oct 9, 2019

niveristand-diff-bot commented Oct 9, 2019

Validate input references (CDs, sections, channels) #107

Validate input references (CDs, sections, channels) #107

Conversation

mdcerna commented Oct 7, 2019

What does this Pull Request accomplish?

Why should this Pull Request be merged?

What testing has been done?

niveristand-diff-bot commented Oct 7, 2019

niveristand-diff-bot commented Oct 7, 2019

csjall commented Oct 8, 2019 • edited by mdcerna Loading

niveristand-diff-bot commented Oct 8, 2019

niveristand-diff-bot commented Oct 8, 2019

niveristand-diff-bot commented Oct 8, 2019

niveristand-diff-bot commented Oct 8, 2019

csjall commented Oct 9, 2019 • edited by mdcerna Loading

mdcerna commented Oct 9, 2019

niveristand-diff-bot commented Oct 9, 2019

niveristand-diff-bot commented Oct 9, 2019

csjall commented Oct 8, 2019 •

edited by mdcerna

Loading

csjall commented Oct 9, 2019 •

edited by mdcerna

Loading