Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to style dictionary v4 #2353

Merged
merged 8 commits into from
Aug 20, 2024
Merged

Switch to style dictionary v4 #2353

merged 8 commits into from
Aug 20, 2024

Conversation

rajsite
Copy link
Member

@rajsite rajsite commented Aug 20, 2024

Pull Request

🤨 Rationale

This PR represents the minimal set of changes to get to style dictionary v4. Perks of being on style dictionary v4 are:

Fixes #2232

👩‍💻 Implementation

  • Switched the package to "type": "module" which required updated legacy cjs scripts
  • Tokens now use a type field instead of relying on the json hierarchy for type information. Migrated just the tokens that needed an explicit type to evaluate correctly (likely want to redo the structure after experimenting with Figma output so did the bare minimum required changes)
  • Re-enabled renovate updates for style-dicitionary

🧪 Testing

  • Validated manually that the generated output had no effective difference (other than generated comments) compared to [email protected]
  • Triggered the storybook rebuild to validate no visual differences

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@rajsite rajsite changed the title Static css proto Switch to style dictionary v4 Aug 20, 2024
@rajsite rajsite marked this pull request as ready for review August 20, 2024 20:41
@rajsite rajsite enabled auto-merge (squash) August 20, 2024 21:49
@rajsite rajsite merged commit b3e8a10 into main Aug 20, 2024
13 checks passed
@rajsite rajsite deleted the static-css-proto branch August 20, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adopting Style Dictionary v4
2 participants