Skip to content

Commit

Permalink
Add and update latest icons (#2468)
Browse files Browse the repository at this point in the history
# Pull Request

## 🀨 Rationale

Fixes #2466

## πŸ‘©β€πŸ’» Implementation

Followed CONTRIBUTING. Brandon's proposed names matched FontAwesome with
the following exceptions:
1. paper-airplane -> paper-plane
2. star-8-point -> no font awesome equivalent, went with Brandon's
suggestion
3. rectangle-lines -> no font awesome equivalent, went with Brandon's
suggestion (name aligns with existing rectangle-check-lines)

## πŸ§ͺ Testing

Verified changing severity affects color of new icons
Accepted Chromatic diffs. There are a lot because the pencil icon is
used in many matrix tests

## βœ… Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.

---------

Co-authored-by: Fred Visser <[email protected]>
  • Loading branch information
jattasNI and fredvisser authored Nov 14, 2024
1 parent c977172 commit bd0d274
Show file tree
Hide file tree
Showing 13 changed files with 76 additions and 7 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "Add / update several icons",
"packageName": "@ni/nimble-components",
"email": "[email protected]",
"dependentChangeType": "minor"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "Add / update several icons",
"packageName": "@ni/nimble-tokens",
"email": "[email protected]",
"dependentChangeType": "patch"
}
21 changes: 21 additions & 0 deletions packages/nimble-components/src/icon-base/tests/icon-metadata.ts
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,9 @@ export const iconMetadata: {
IconLayerGroup: {
tags: ['jobs']
},
IconLightbulb: {
tags: ['suggested', 'prompt', 'idea', 'think']
},
IconLightningBolt: {
tags: ['active jobs']
},
Expand Down Expand Up @@ -409,6 +412,9 @@ export const iconMetadata: {
IconMarkdown: {
tags: []
},
IconMicrophone: {
tags: ['talk to text', 'speech', 'speak', 'sound', 'audio']
},
IconMinus: {
tags: ['mixed checkbox']
},
Expand All @@ -418,6 +424,9 @@ export const iconMetadata: {
IconMobile: {
tags: ['phone']
},
IconMountainSun: {
tags: ['image', 'browse']
},
IconNi: {
tags: ['National Instruments', 'logo', 'product']
},
Expand All @@ -433,6 +442,12 @@ export const iconMetadata: {
IconOutwardSquaresThree: {
tags: ['undeploy']
},
IconPaperclip: {
tags: ['attachment', 'add document', 'browse']
},
IconPaperPlane: {
tags: ['send', 'relay', 'submit']
},
IconPaste: {
tags: ['clipboard']
},
Expand All @@ -454,6 +469,9 @@ export const iconMetadata: {
IconRectangleCheckLines: {
tags: ['test', 'plan']
},
IconRectangleLines: {
tags: ['defined', 'paper', 'paragraph', 'sentence', 'words']
},
IconRunningArrow: {
tags: ['status', 'running']
},
Expand Down Expand Up @@ -502,6 +520,9 @@ export const iconMetadata: {
IconSquareX: {
tags: ['quit', 'end', 'abort', 'stop', 'terminate']
},
IconStar8Point: {
tags: ['create new', 'burst']
},
IconStopSquare: {
tags: ['quit', 'end']
},
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions packages/nimble-tokens/dist/icons/svg/lightbulb_16x16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 7 additions & 0 deletions packages/nimble-tokens/dist/icons/svg/microphone_16x16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions packages/nimble-tokens/dist/icons/svg/mountain-sun_16x16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions packages/nimble-tokens/dist/icons/svg/paper-plane_16x16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions packages/nimble-tokens/dist/icons/svg/paperclip_16x16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 4 additions & 3 deletions packages/nimble-tokens/dist/icons/svg/pencil_16x16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions packages/nimble-tokens/dist/icons/svg/star-8-point_16x16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/storybook/.storybook/preview.js
Original file line number Diff line number Diff line change
Expand Up @@ -105,5 +105,5 @@ configureActions({
depth: 1
});

// Update the GUID on this line to trigger a turbosnap full rebuild: c9f91cc3-1168-433f-86e7-b93a9e395ba2
// Update the GUID on this line to trigger a turbosnap full rebuild: d3f8a1b2-4c5d-4e7f-8a9e-1b2c3d4e5f6a
// See https://www.chromatic.com/docs/turbosnap/#full-rebuilds

0 comments on commit bd0d274

Please sign in to comment.