Skip to content

Commit

Permalink
adjust parameters for ripple, remove eslint err
Browse files Browse the repository at this point in the history
  • Loading branch information
nhtoby311 committed Mar 7, 2024
1 parent 544ce53 commit 5f49756
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
1 change: 1 addition & 0 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@ module.exports = {
],
'@typescript-eslint/no-explicit-any': 'off',
'@typescript-eslint/no-unused-vars': 'off',
'@typescript-eslint/no-this-alias': 'off',
},
};
13 changes: 7 additions & 6 deletions src/Scene.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ export default function Scene() {

rippleFX: folder(
{
alpha: 0.6,
fadeout_speed: 0.9,
alpha: 1.0,
fadeout_speed: 0.94,
frequency: 0.01,
rotation: 0.05,
scale: 0.3,
rotation: 0.02,
scale: 0.06,
},
{ render: (get) => get('fxType') === 'ripple' }
),
Expand Down Expand Up @@ -78,7 +78,7 @@ export default function Scene() {
<>
<Perf position={'top-left'} />

<Environment preset='park' background />
<Environment preset='studio' background />

<ambientLight />
<mesh>
Expand All @@ -90,7 +90,8 @@ export default function Scene() {
<WaterSurfaceSimple
fxType={controls.fxType}
width={controls.planeSize.width}
length={controls.planeSize.length}>
length={controls.planeSize.length}
fxDisplayColor={true}>
{FX_RENDER}
</WaterSurfaceSimple>
)}
Expand Down
4 changes: 2 additions & 2 deletions src/WaterSurface/InteractiveFX/RippleFX.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ export default function RippleFX({
frequency = 0.01,
rotation = 0.05,
fadeout_speed = 0.9,
scale = 0.3,
alpha = 0.6,
scale = 0.2,
alpha = 1.0,
}: FXRippleProps) {
const { ref: materialRef, refPointer } = useContext(WaterContext);

Expand Down
1 change: 0 additions & 1 deletion src/WaterSurface/Water/WaterComplex.ts
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,6 @@ class WaterComplex extends Mesh {

//this.type = 'Water';

// eslint-disable-next-line @typescript-eslint/no-this-alias
const scope = this;

const color =
Expand Down
1 change: 0 additions & 1 deletion src/WaterSurface/Water/WaterSimple.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ class WaterSimple extends Mesh {

//this.isWater = true;

// eslint-disable-next-line @typescript-eslint/no-this-alias
const scope = this;

const textureWidth =
Expand Down

0 comments on commit 5f49756

Please sign in to comment.