Pass R CMD check following addition of {lintr} #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomUK
approved these changes
Mar 8, 2024
|
Is there a way of disabling the linter complaining about code comments? |
Ha, those are my fault! Those will go away once I properly submit my PR for function-input error handling (the commented lines are all tests that Chris helpfully pre-wrote for my error handling functions). We could also adjust the linter's behaviour to ignore it, but I think it's a good rule to keep; we shouldn't have commented-out code. Happy for the group to talk it all through at the next meeting. |
|
@all-contributors please add @matt-dray for code |
|
I've put up a pull request to add @matt-dray! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had failed to run an R CMD check before pushing the {lintr} GitHub Action. This PR fixes the outstanding issues and closes #48.