Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for nhspy pandas_spc_calculations #16

Merged
merged 7 commits into from
Jul 11, 2024
Merged

Unit tests for nhspy pandas_spc_calculations #16

merged 7 commits into from
Jul 11, 2024

Conversation

v-Morriss
Copy link
Contributor

@v-Morriss v-Morriss commented Jul 9, 2024 •
edited
Loading

This request adds unit tests for the functions listed in #7.

@v-Morriss v-Morriss marked this pull request as ready for review July 9, 2024 16:09
@v-Morriss v-Morriss changed the title Initial test Unit tests for nhspy pandas_spc_calculations Jul 9, 2024
@v-Morriss v-Morriss marked this pull request as draft July 9, 2024 16:20
@v-Morriss v-Morriss marked this pull request as ready for review July 9, 2024 16:24
@v-Morriss v-Morriss marked this pull request as draft July 10, 2024 08:40
@v-Morriss v-Morriss marked this pull request as ready for review July 10, 2024 09:29
@v-Morriss v-Morriss marked this pull request as draft July 10, 2024 09:29
@v-Morriss v-Morriss marked this pull request as ready for review July 10, 2024 14:15
tomjemmett
tomjemmett suggested changes Jul 10, 2024
View reviewed changes
tests/unittests/part_of_two_in_three.py Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be named test_part_of_two_in_three.py

@tomjemmett
Copy link

@craig-shenton I've reviewed this and checked the tests, they all pass.

@craig-shenton
Copy link
Member

@craig-shenton I've reviewed this and checked the tests, they all pass.

Great thanks.

@craig-shenton craig-shenton self-requested a review July 11, 2024 14:09
craig-shenton
craig-shenton approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@craig-shenton craig-shenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@craig-shenton craig-shenton merged commit bfdefe4 into nhs-pycom:main Jul 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig-shenton craig-shenton craig-shenton approved these changes

@tomjemmett tomjemmett tomjemmett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v-Morriss @tomjemmett @craig-shenton @maurice-borys