bug fix: uncaught error within TranslateService.use() #827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When use the
use()
method ofTranslateService
to load an invalid language, it will result nothing. For example, the fileassets/i18n/vvvv.json
does not exist, so the"vvvv"
language is invalid:The code above will not output anything.
Because there is an uncaught error within the
use()
method:If the language file is missing, this code will break the running, the other subscribers of
pending
will be halt, missing the data ofnext()
,error()
orcomplete()
.Adding a void error handler will fix this bug.