-
-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix service configuration with isolate = true #531
base: master
Are you sure you want to change the base?
Conversation
Hmm so what does it change actually? Could I get some tests to make sure that it fixes the problem ? |
@ocombe I don't know if it works, but the idea of not having to sync the children modules with the root one is clearly a good one. As said in my comment on another PR, the current |
When will this be released ? |
Once the PR has some tests :) |
so, no tests after 14 days, i guess i will stick with the workaround, or provide my own translation service... |
Any updates here ? |
8dd86e6
to
303b81f
Compare
This fix would be really welcome |
Guys, are you going to merge this change into the main branch? We could really use this useful change! |
can any one please review and merge this pull request.Thanks in Advance. |
Anybody who could resolve the conflict and approve this pr? |
no more need to repeat
setDefaultLang
anduse
on every service in lazy loaded modules