-
-
Notifications
You must be signed in to change notification settings - Fork 582
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(TranslateCompiler): new compiler that you can override to pre-pr…
…ocess translations Whenever translations are added (manually or by a loader), they are passed to the compiler for pre-processing. The default (TranslateFakeCompiler) does nothing.
- Loading branch information
Showing
7 changed files
with
196 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import {Injectable} from "@angular/core"; | ||
|
|
||
| export abstract class TranslateCompiler { | ||
| abstract compile(value: string, lang: string): string | Function; | ||
| abstract compileTranslations(translations: any, lang: string): any; | ||
| } | ||
|
|
||
| /** | ||
| * This compiler is just a placeholder that does nothing, in case you don't need a compiler at all | ||
| */ | ||
| @Injectable() | ||
| export class TranslateFakeCompiler extends TranslateCompiler { | ||
| compile(value: string, lang: string): string | Function { | ||
| return value; | ||
| } | ||
|
|
||
| compileTranslations(translations: any, lang: string): any { | ||
| return translations; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| import {Injector} from "@angular/core"; | ||
| import {TestBed, getTestBed} from "@angular/core/testing"; | ||
| import {TranslateService, TranslateModule, TranslateLoader, TranslateCompiler, TranslateFakeCompiler} from "../index"; | ||
| import {Observable} from "rxjs/Observable"; | ||
|
|
||
| let translations: any = {LOAD: 'This is a test'}; | ||
|
|
||
| class FakeLoader implements TranslateLoader { | ||
| getTranslation(lang: string): Observable<any> { | ||
| return Observable.of(translations); | ||
| } | ||
| } | ||
|
|
||
| describe('TranslateCompiler', () => { | ||
| let injector: Injector; | ||
| let translate: TranslateService; | ||
|
|
||
| let prepare = (_injector: Injector) => { | ||
| translate = _injector.get(TranslateService); | ||
| }; | ||
|
|
||
| describe('with default TranslateFakeCompiler', () => { | ||
| beforeEach(() => { | ||
| TestBed.configureTestingModule({ | ||
| imports: [ | ||
| TranslateModule.forRoot({ | ||
| loader: {provide: TranslateLoader, useClass: FakeLoader}, | ||
| compiler: {provide: TranslateCompiler, useClass: TranslateFakeCompiler} | ||
| }) | ||
| ], | ||
| }); | ||
| injector = getTestBed(); | ||
| prepare(injector); | ||
|
|
||
| translate.use('en'); | ||
| }); | ||
|
|
||
| it('should use the correct compiler', () => { | ||
| expect(translate).toBeDefined(); | ||
| expect(translate.compiler).toBeDefined(); | ||
| expect(translate.compiler instanceof TranslateFakeCompiler).toBeTruthy(); | ||
| }); | ||
|
|
||
| it('should use the compiler on loading translations', () => { | ||
| translate.get('LOAD').subscribe((res: string) => { | ||
| expect(res).toBe('This is a test'); | ||
| }); | ||
| }); | ||
|
|
||
| it('should use the compiler on manually adding a translation object', () => { | ||
| translate.setTranslation('en', {'SET-TRANSLATION': 'A manually added translation'}); | ||
| expect(translate.instant('SET-TRANSLATION')).toBe('A manually added translation'); | ||
| }); | ||
|
|
||
| it('should use the compiler on manually adding a single translation', () => { | ||
| translate.set('SET', 'Another manually added translation', 'en'); | ||
| expect(translate.instant('SET')).toBe('Another manually added translation'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('with a custom compiler implementation', () => { | ||
| class CustomCompiler implements TranslateCompiler { | ||
| compile(value: string, lang: string): string { | ||
| return value + '|compiled'; | ||
| } | ||
| compileTranslations(translation: any, lang: string): Object { | ||
| return Object.keys(translation).reduce((acc: any, key) => { | ||
| acc[key] = () => translation[key] + '|compiled'; | ||
| return acc; | ||
| }, {}); | ||
| } | ||
| } | ||
|
|
||
| beforeEach(() => { | ||
| TestBed.configureTestingModule({ | ||
| imports: [ | ||
| TranslateModule.forRoot({ | ||
| loader: {provide: TranslateLoader, useClass: FakeLoader}, | ||
| compiler: {provide: TranslateCompiler, useClass: CustomCompiler} | ||
| }) | ||
| ], | ||
| }); | ||
| injector = getTestBed(); | ||
| prepare(injector); | ||
|
|
||
| translate.use('en'); | ||
| }); | ||
|
|
||
| it('should use the correct compiler', () => { | ||
| expect(translate).toBeDefined(); | ||
| expect(translate.compiler).toBeDefined(); | ||
| expect(translate.compiler instanceof CustomCompiler).toBeTruthy(); | ||
| }); | ||
|
|
||
| it('should use the compiler on loading translations', () => { | ||
| translate.get('LOAD').subscribe((res: string) => { | ||
| expect(res).toBe('This is a test|compiled'); | ||
| }); | ||
| }); | ||
|
|
||
| it('should use the compiler on manually adding a translation object', () => { | ||
| translate.setTranslation('en', {'SET-TRANSLATION': 'A manually added translation'}); | ||
| expect(translate.instant('SET-TRANSLATION')).toBe('A manually added translation|compiled'); | ||
| }); | ||
|
|
||
| it('should use the compiler on manually adding a single translation', () => { | ||
| translate.set('SET', 'Another manually added translation', 'en'); | ||
| expect(translate.instant('SET')).toBe('Another manually added translation|compiled'); | ||
| }); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters