Add Agorakit nixpkgs and NixOS refs #421
Draft
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fricklerhandwerk
requested changes
Nov 21, 2024
projects/Agorakit/default.nix
Outdated
| }; | ||
| nixos = { | ||
| modules.services.agorakit = "${sources.inputs.nixpkgs}/nixos/modules/services/web-apps/agorakit.nix"; | ||
| tests.agorakit = null; |
There was a problem hiding this comment.
Suggested change
| tests.agorakit = null; | |
| tests = null; |
Our invocation of the tests fails because you gave it tests.agorakit that was supposed to be a test but is null. Our filter only removes tests if the whole attribute set is null.
There was a problem hiding this comment.
It doesn't seem to be that though. Maybe a Nixpkgs bump is needed then?
Co-authored-by: Valentin Gagarin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no dedicated test yet, therefore it was defined as
null.The build fails though with the following error.
Maybe something along the lines of jq breaking the css file due to too many items? Can't really tell from the get go.