Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_noise.m: Apply SigmaZeroSFPoly to measured noise value #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jordan-heemskerk
Copy link

No description provided.

Copy link
Contributor

@utwade utwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Radiometric.NoiseLevel.NoisePoly is an absolute measure, not a calibrated measure.

It would be OK to display measured noise in sigma-0 (and probably even preferable, since that's what most SAR people speak in), but we would need to apply the scale factor to both the predicted and measured numbers, not just one. RCSTool.m has an example of code displaying predicted noise in a calibrated way.

Also, it is possible for a SICD to have NoisePoly populated, but not SigmaZeroSFPoly, since they are both optional, so we would want it to work both ways to be completely generic.

If you make it consistent across predicted/measured, and allow for the scenario where SigmaZeroSFPoly is not populated, I will approve merge request.

@jordan-heemskerk
Copy link
Author

My mistake @utwade, I misunderstood the content of Radiometric.NoiseLevel.NoisePoly. I'll leave this as a TODO, but not sure I have the bandwidth right now to add full support for calibrated noise measurements. Thanks for your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants