Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redact paths with option names containing "directory" #263

Merged
merged 2 commits into from
Nov 29, 2024
Merged

redact paths with option names containing "directory" #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca007a9
redact paths with option names containing "directory"
mrcaseb Nov 29, 2024
a98c452
news bullet
mrcaseb Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: nflreadr
Title: Download 'nflverse' Data
Version: 1.4.1.05
Version: 1.4.1.06
Authors@R: c(
person("Tan", "Ho", , "[email protected]", role = c("aut", "cre", "cph"),
comment = c(ORCID = "0000-0001-8388-5155")),
Expand Down
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ across all nflverse data. When printing to the console, nflreadr will convert ti
- Added a dictionary to describe what each shorthand roster status indicates (#232)
- `clean_team_abbrs()` now converts `"PHO"` to `"ARI"`. (#260)
- Improved description of next score probability variables in `nflreadr::dictionary_pbp`. (#262)
- `.sitrep` and all `*_sitrep` functions now redact nflfastR option paths. (#263)

---

Expand Down
2 changes: 1 addition & 1 deletion R/utils_sitrep.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ ffverse_sitrep <- function(pkg = c("ffscrapr", "ffsimulator", "ffpros", "ffoppor
pkg_search_string <- paste(packages, collapse = "|")
package_options <- opts[grepl(pkg_search_string, x = names(opts))]
if(redact_path) {
package_options[grepl("path|token|auth", names(package_options))] <- "{redacted, use redact_path = FALSE to show}"
package_options[grepl("path|token|auth|directory", names(package_options))] <- "{redacted, use redact_path = FALSE to show}"
}
return(package_options)
}
Expand Down
Loading